Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2682793003: aura-mus: Destroy the capture client before the tree client in TestWM. (Closed)

Created:
3 years, 10 months ago by Elliot Glaysher
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura-mus: Destroy the capture client before the tree client in TestWM. Now that we don't crash on the beginning of shutdown, we get to the point where we crash in yesterday's changes to TestWM. Ensure that the DefaultCaptureClient added yesterday is destroyed before we try to destroy the WindowTreeHost. views_mus_interactive_ui_tests is now crash-free locally. BUG=689197 Review-Url: https://codereview.chromium.org/2682793003 Cr-Commit-Position: refs/heads/master@{#448830} Committed: https://chromium.googlesource.com/chromium/src/+/78c9144a00abf91237afd62d3fadea59f78298e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M services/ui/test_wm/test_wm.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Elliot Glaysher
3 years, 10 months ago (2017-02-07 23:14:46 UTC) #6
sky
LGTM
3 years, 10 months ago (2017-02-08 01:00:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682793003/1
3 years, 10 months ago (2017-02-08 01:01:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 01:20:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78c9144a00abf91237afd62d3fad...

Powered by Google App Engine
This is Rietveld 408576698