Issue 268273002: [webcrypto] Make KeyPair structured clonable.

Issue 268273002: [webcrypto] Make KeyPair structured clonable. (Closed)

Created:
6 years, 7 months ago by eroman

Modified:
6 years, 7 months ago

Reviewers:
jsbell, abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, blink-reviews-bindings_chromium.org, haraken, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[webcrypto] Make KeyPair structured clonable. BUG=368916, 245025

Patch Set 1 #

Total comments: 11

Patch Set 2 : Address jsbell comments #

Patch Set 3 : Update test expectations to match previous changes! #

Patch Set 4 : change up comment once more #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -9 lines)			Patch
A	LayoutTests/crypto/clone-rsaKeyPair.html	View	1 2 3	1 chunk	+97 lines, -0 lines	0 comments	Download
A	LayoutTests/crypto/clone-rsaKeyPair-expected.txt	View	1 2	1 chunk	+37 lines, -0 lines	0 comments	Download
M	LayoutTests/crypto/resources/common.js	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/SerializedScriptValue.cpp	View	1	9 chunks	+53 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Should we have jsbell review the SerializedScriptValue changes?

6 years, 7 months ago (2014-05-06 04:26:33 UTC) #2

jsbell

lgtm I'm okay with not bumping the version here, since I believe the introduction of ...

6 years, 7 months ago (2014-05-06 20:38:09 UTC) #3

eroman

https://codereview.chromium.org/268273002/diff/1/LayoutTests/crypto/clone-rsaKeyPair.html File LayoutTests/crypto/clone-rsaKeyPair.html (right): https://codereview.chromium.org/268273002/diff/1/LayoutTests/crypto/clone-rsaKeyPair.html#newcode79 LayoutTests/crypto/clone-rsaKeyPair.html:79: shouldBeTrue("generatedKeyPair != clonedKeyPair"); On 2014/05/06 20:38:09, jsbell wrote: > ...

6 years, 7 months ago (2014-05-06 21:35:17 UTC) #4

eroman

6 years, 7 months ago (2014-05-06 22:21:15 UTC) #5

Turns out this is not spec compliant, will abandon this change.

More details on the bug.

Very sorry for taking up your review time jsbell :(

Expand Messages | Collapse Messages