Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 2682723002: Convert HandoffActiveURLObserver to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert HandoffActiveURLObserver to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2682723002 Cr-Commit-Position: refs/heads/master@{#448661} Committed: https://chromium.googlesource.com/chromium/src/+/f307f287d11e34cee8507cf7cd04102479aa809e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/handoff_active_url_observer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/handoff_active_url_observer.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
jam
3 years, 10 months ago (2017-02-07 17:19:07 UTC) #12
Avi (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-07 17:30:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682723002/20001
3 years, 10 months ago (2017-02-07 17:42:10 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 17:48:14 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f307f287d11e34cee8507cf7cd04...

Powered by Google App Engine
This is Rietveld 408576698