Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2682713002: X87: [wasm] Introduce WasmToInterpreterFrame. (Closed)

Created:
3 years, 10 months ago by zhengxing.li
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Introduce WasmToInterpreterFrame. port 81700ddfdc579c54e03d4d26fc0331fc13f92aca(r42213) original commit message: and rename WasmFrame to WasmCompiledFrame. The WasmToInterpreterFrames are not used yet; this will follow in a follow-up CL (see tracking bug for the overall picture). Those frames will represent frames for WASM_TO_INTERPRETER stubs, which call from wasm code to the wasm interpreter, implemented in C++. They will support the Summarize method to inspect the stack frames in the wasm interpreter. BUG= Review-Url: https://codereview.chromium.org/2682713002 Cr-Commit-Position: refs/heads/master@{#43023} Committed: https://chromium.googlesource.com/v8/v8/+/3c97959a7dd09b3d59501f2f6e1a4615dbad412f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
zhengxing.li
PTAL, thanks!
3 years, 10 months ago (2017-02-07 14:49:48 UTC) #2
chunyang.dai
On 2017/02/07 14:49:48, zhengxing.li wrote: > PTAL, thanks! LGTM. thanks
3 years, 10 months ago (2017-02-08 02:23:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682713002/1
3 years, 10 months ago (2017-02-08 02:25:24 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-08 02:25:25 UTC) #7
Clemens Hammacher
lgtm
3 years, 10 months ago (2017-02-08 04:39:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682713002/1
3 years, 10 months ago (2017-02-08 04:40:22 UTC) #10
zhengxing.li
On 2017/02/08 04:39:04, Clemens Hammacher wrote: > lgtm Thanks, Clements!
3 years, 10 months ago (2017-02-08 04:41:13 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 04:59:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3c97959a7dd09b3d59501f2f6e1a4615dba...

Powered by Google App Engine
This is Rietveld 408576698