Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: src/code-stubs.h

Issue 26827002: Allow FastCloneShallowObjectStub to use AllocationMementos. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comment response Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index d2101ae293b6cee60ef3ca597bc483ab9b4d18ba..d1d389c74e635db6416554d26efc8f7f775016f9 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -690,8 +690,13 @@ class FastCloneShallowObjectStub : public HydrogenCodeStub {
private:
int length_;
+ // Ensure data fits within available bits.
+ STATIC_ASSERT(kMaximumClonedProperties < 16);
Michael Starzinger 2013/10/11 07:49:37 nit: Assert is obsolete now.
mvstanton 2013/10/11 09:23:47 Done.
+
Major MajorKey() { return FastCloneShallowObject; }
- int NotMissMinorKey() { return length_; }
+ int NotMissMinorKey() {
Michael Starzinger 2013/10/11 07:49:37 nit: Unnecessary white-space change, still fits in
mvstanton 2013/10/11 09:23:47 Done.
+ return length_;
+ }
DISALLOW_COPY_AND_ASSIGN(FastCloneShallowObjectStub);
};
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698