Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/code-stubs.h

Issue 26827002: Allow FastCloneShallowObjectStub to use AllocationMementos. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comment response Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 672 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 683
684 virtual Handle<Code> GenerateCode(Isolate* isolate); 684 virtual Handle<Code> GenerateCode(Isolate* isolate);
685 685
686 virtual void InitializeInterfaceDescriptor( 686 virtual void InitializeInterfaceDescriptor(
687 Isolate* isolate, 687 Isolate* isolate,
688 CodeStubInterfaceDescriptor* descriptor); 688 CodeStubInterfaceDescriptor* descriptor);
689 689
690 private: 690 private:
691 int length_; 691 int length_;
692 692
693 // Ensure data fits within available bits.
694 STATIC_ASSERT(kMaximumClonedProperties < 16);
Michael Starzinger 2013/10/11 07:49:37 nit: Assert is obsolete now.
mvstanton 2013/10/11 09:23:47 Done.
695
693 Major MajorKey() { return FastCloneShallowObject; } 696 Major MajorKey() { return FastCloneShallowObject; }
694 int NotMissMinorKey() { return length_; } 697 int NotMissMinorKey() {
Michael Starzinger 2013/10/11 07:49:37 nit: Unnecessary white-space change, still fits in
mvstanton 2013/10/11 09:23:47 Done.
698 return length_;
699 }
695 700
696 DISALLOW_COPY_AND_ASSIGN(FastCloneShallowObjectStub); 701 DISALLOW_COPY_AND_ASSIGN(FastCloneShallowObjectStub);
697 }; 702 };
698 703
699 704
700 class CreateAllocationSiteStub : public HydrogenCodeStub { 705 class CreateAllocationSiteStub : public HydrogenCodeStub {
701 public: 706 public:
702 explicit CreateAllocationSiteStub() { } 707 explicit CreateAllocationSiteStub() { }
703 708
704 virtual Handle<Code> GenerateCode(Isolate* isolate); 709 virtual Handle<Code> GenerateCode(Isolate* isolate);
(...skipping 1651 matching lines...) Expand 10 before | Expand all | Expand 10 after
2356 int MinorKey() { return 0; } 2361 int MinorKey() { return 0; }
2357 2362
2358 void Generate(MacroAssembler* masm); 2363 void Generate(MacroAssembler* masm);
2359 2364
2360 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub); 2365 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub);
2361 }; 2366 };
2362 2367
2363 } } // namespace v8::internal 2368 } } // namespace v8::internal
2364 2369
2365 #endif // V8_CODE_STUBS_H_ 2370 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698