Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2682683005: Remove pre-MD code/assets for network iconography. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pre-MD code/assets for network iconography. BUG=686233 Review-Url: https://codereview.chromium.org/2682683005 Cr-Commit-Position: refs/heads/master@{#449358} Committed: https://chromium.googlesource.com/chromium/src/+/e7f0828e30d63a0c2c5a7113237af8ecb41cfca8

Patch Set 1 #

Patch Set 2 : ready #

Patch Set 3 : rename #

Patch Set 4 : actually remove assets #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -209 lines) Patch
M ash/common/system/chromeos/network/network_icon.cc View 1 2 19 chunks +41 lines, -179 lines 1 comment Download
M ash/resources/ash_resources.grd View 1 1 chunk +0 lines, -30 lines 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_1x.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_3g_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_3g_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_4g_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_4g_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_arcs_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_arcs_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_bars_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_bars_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_edge_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_edge_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_evdo_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_evdo_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_gprs_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_gprs_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_roaming_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_roaming_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_secure_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_vpn_badge.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_wired.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/status_wifi_enabled.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_3g_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_3g_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_4g_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_4g_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_arcs_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_arcs_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_bars_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_bars_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_edge_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_edge_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_evdo_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_evdo_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_gprs_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_gprs_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_roaming_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_roaming_light.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_secure_dark.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_vpn_badge.png View 1 2 3 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_wired.png View 1 2 3 Binary file 0 comments Download

Messages

Total messages: 15 (11 generated)
Evan Stade
3 years, 10 months ago (2017-02-08 22:24:11 UTC) #4
tdanderson
LGTM and good riddance to all of these PNGs! https://codereview.chromium.org/2682683005/diff/60001/ash/common/system/chromeos/network/network_icon.cc File ash/common/system/chromeos/network/network_icon.cc (right): https://codereview.chromium.org/2682683005/diff/60001/ash/common/system/chromeos/network/network_icon.cc#newcode457 ash/common/system/chromeos/network/network_icon.cc:457: ...
3 years, 10 months ago (2017-02-09 18:23:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682683005/60001
3 years, 10 months ago (2017-02-09 18:30:02 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 18:37:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e7f0828e30d63a0c2c5a7113237a...

Powered by Google App Engine
This is Rietveld 408576698