Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2682593006: Gtk3: Bugfixes on several themes (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Bugfixes on several themes This CL: * Fixes hovered menuitem text colors. * Fixes background colors on Gtk3.20 for widgets that have a non-square minimum size. * Fixes a divide-by-zero error in GetAveragePixelValue() BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2682593006 Cr-Commit-Position: refs/heads/master@{#448743} Committed: https://chromium.googlesource.com/chromium/src/+/e5f19f64a46e9d607192697105b7db46f79e298c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Tom (Use chromium acct)
3 years, 10 months ago (2017-02-07 21:03:26 UTC) #2
Elliot Glaysher
lgtm strides strike again!
3 years, 10 months ago (2017-02-07 21:07:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682593006/1
3 years, 10 months ago (2017-02-07 21:12:16 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:26:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5f19f64a46e9d607192697105b7...

Powered by Google App Engine
This is Rietveld 408576698