Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1960)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2682593004: Disable flaky PageLoadMetricsBrowserTests on Linux (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index 3fe20efd4febec2441e0edd71de4c234826849b2..a9c4f95aaefd8c1a784d23fd795b897011129fcb 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -515,8 +515,15 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
}
+// Flaky on Linux (timing out or failing in an expectation) crbug.com/657022
+#if defined(OS_LINUX)
+#define MAYBE_NoStatePrefetchObserverCacheable \
+ DISABLED_NoStatePrefetchObserverCacheable
+#else
+#define MAYBE_NoStatePrefetchObserverCacheable NoStatePrefetchObserverCacheable
+#endif
IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
- NoStatePrefetchObserverCacheable) {
+ MAYBE_NoStatePrefetchObserverCacheable) {
ASSERT_TRUE(embedded_test_server()->Start());
ui_test_utils::NavigateToURL(browser(),
@@ -529,8 +536,15 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
"Prerender.none_PrefetchTTFCP.Reference.Cacheable.Visible", 1);
}
+// Flaky on Linux (timing out or failing in an expectation) crbug.com/657022
+#if defined(OS_LINUX)
+#define MAYBE_NoStatePrefetchObserverNoStore \
+ DISABLED_NoStatePrefetchObserverNoStore
+#else
+#define MAYBE_NoStatePrefetchObserverNoStore NoStatePrefetchObserverNoStore
+#endif
IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
- NoStatePrefetchObserverNoStore) {
+ MAYBE_NoStatePrefetchObserverNoStore) {
ASSERT_TRUE(embedded_test_server()->Start());
ui_test_utils::NavigateToURL(browser(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698