Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2682593004: Disable flaky PageLoadMetricsBrowserTests on Linux (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/scoped_temp_dir.h" 5 #include "base/files/scoped_temp_dir.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/test/histogram_tester.h" 7 #include "base/test/histogram_tester.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 508
509 histogram_tester_.ExpectUniqueSample( 509 histogram_tester_.ExpectUniqueSample(
510 internal::kHistogramFirstMeaningfulPaintStatus, 510 internal::kHistogramFirstMeaningfulPaintStatus,
511 internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE, 1); 511 internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE, 1);
512 histogram_tester_.ExpectTotalCount( 512 histogram_tester_.ExpectTotalCount(
513 internal::kHistogramFirstMeaningfulPaint, 0); 513 internal::kHistogramFirstMeaningfulPaint, 0);
514 histogram_tester_.ExpectTotalCount( 514 histogram_tester_.ExpectTotalCount(
515 internal::kHistogramParseStartToFirstMeaningfulPaint, 0); 515 internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
516 } 516 }
517 517
518 // Flaky on Linux (timing out or failing in an expectation) crbug.com/657022
519 #if defined(OS_LINUX)
520 #define MAYBE_NoStatePrefetchObserverCacheable \
521 DISABLED_NoStatePrefetchObserverCacheable
522 #else
523 #define MAYBE_NoStatePrefetchObserverCacheable NoStatePrefetchObserverCacheable
524 #endif
518 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, 525 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
519 NoStatePrefetchObserverCacheable) { 526 MAYBE_NoStatePrefetchObserverCacheable) {
520 ASSERT_TRUE(embedded_test_server()->Start()); 527 ASSERT_TRUE(embedded_test_server()->Start());
521 528
522 ui_test_utils::NavigateToURL(browser(), 529 ui_test_utils::NavigateToURL(browser(),
523 embedded_test_server()->GetURL("/title1.html")); 530 embedded_test_server()->GetURL("/title1.html"));
524 NavigateToUntrackedUrl(); 531 NavigateToUntrackedUrl();
525 532
526 histogram_tester_.ExpectTotalCount( 533 histogram_tester_.ExpectTotalCount(
527 "Prerender.none_PrefetchTTFCP.Reference.NoStore.Visible", 0); 534 "Prerender.none_PrefetchTTFCP.Reference.NoStore.Visible", 0);
528 histogram_tester_.ExpectTotalCount( 535 histogram_tester_.ExpectTotalCount(
529 "Prerender.none_PrefetchTTFCP.Reference.Cacheable.Visible", 1); 536 "Prerender.none_PrefetchTTFCP.Reference.Cacheable.Visible", 1);
530 } 537 }
531 538
539 // Flaky on Linux (timing out or failing in an expectation) crbug.com/657022
540 #if defined(OS_LINUX)
541 #define MAYBE_NoStatePrefetchObserverNoStore \
542 DISABLED_NoStatePrefetchObserverNoStore
543 #else
544 #define MAYBE_NoStatePrefetchObserverNoStore NoStatePrefetchObserverNoStore
545 #endif
532 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, 546 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
533 NoStatePrefetchObserverNoStore) { 547 MAYBE_NoStatePrefetchObserverNoStore) {
534 ASSERT_TRUE(embedded_test_server()->Start()); 548 ASSERT_TRUE(embedded_test_server()->Start());
535 549
536 ui_test_utils::NavigateToURL(browser(), 550 ui_test_utils::NavigateToURL(browser(),
537 embedded_test_server()->GetURL("/nostore.html")); 551 embedded_test_server()->GetURL("/nostore.html"));
538 NavigateToUntrackedUrl(); 552 NavigateToUntrackedUrl();
539 553
540 histogram_tester_.ExpectTotalCount( 554 histogram_tester_.ExpectTotalCount(
541 "Prerender.none_PrefetchTTFCP.Reference.NoStore.Visible", 1); 555 "Prerender.none_PrefetchTTFCP.Reference.NoStore.Visible", 1);
542 histogram_tester_.ExpectTotalCount( 556 histogram_tester_.ExpectTotalCount(
543 "Prerender.none_PrefetchTTFCP.Reference.Cacheable.Visible", 0); 557 "Prerender.none_PrefetchTTFCP.Reference.Cacheable.Visible", 0);
(...skipping 26 matching lines...) Expand all
570 ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL( 584 ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(
571 "/page_load_metrics/large.html")); 585 "/page_load_metrics/large.html"));
572 NavigateToUntrackedUrl(); 586 NavigateToUntrackedUrl();
573 587
574 histogram_tester_.ExpectTotalCount(internal::kHistogramTotalBytes, 1); 588 histogram_tester_.ExpectTotalCount(internal::kHistogramTotalBytes, 1);
575 589
576 // Verify that there is a single sample recorded in the 10kB bucket (the size 590 // Verify that there is a single sample recorded in the 10kB bucket (the size
577 // of the main HTML response). 591 // of the main HTML response).
578 histogram_tester_.ExpectBucketCount(internal::kHistogramTotalBytes, 10, 1); 592 histogram_tester_.ExpectBucketCount(internal::kHistogramTotalBytes, 10, 1);
579 } 593 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698