Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2682593002: Refactor ContentViewClient (4/6) (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 9f97f23f810dfe48d007672441057d7d73deea0c..9bac3b38a25962ce6a92c1e881b4026acea786fb 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -843,11 +843,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
return mContentViewClient;
}
- @CalledByNative
- private void onBackgroundColorChanged(int color) {
- getContentViewClient().onBackgroundColorChanged(color);
- }
-
/**
* @return Viewport width in physical pixels as set from onSizeChanged.
*/
@@ -1851,8 +1846,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
|| scrollOffsetY != mRenderCoordinates.getScrollY();
final boolean topBarChanged = Float.compare(topBarShownPix,
mRenderCoordinates.getContentOffsetYPix()) != 0;
- final boolean bottomBarChanged = Float.compare(bottomBarShownPix, mRenderCoordinates
- .getContentOffsetYPixBottom()) != 0;
final boolean needHidePopupZoomer = contentSizeChanged || scrollChanged;
@@ -1890,15 +1883,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
}
}
- if (topBarChanged) {
- float topBarTranslate = topBarShownPix - browserControlsHeightDp * deviceScale;
- getContentViewClient().onTopControlsChanged(topBarTranslate, topBarShownPix);
- }
- if (bottomBarChanged) {
- float bottomBarTranslate = bottomControlsHeightDp * deviceScale - bottomBarShownPix;
- getContentViewClient().onBottomControlsChanged(bottomBarTranslate, bottomBarShownPix);
- }
-
if (mBrowserAccessibilityManager != null) {
mBrowserAccessibilityManager.notifyFrameInfoInitialized();
}
@@ -2318,11 +2302,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
return mRenderCoordinates.getPageScaleFactor();
}
- @CalledByNative
- private void startContentIntent(String contentUrl, boolean isMainFrame) {
- getContentViewClient().onStartContentIntent(getContext(), contentUrl, isMainFrame);
- }
-
@Override
public void onAccessibilityStateChanged(boolean enabled) {
setAccessibilityState(enabled);

Powered by Google App Engine
This is Rietveld 408576698