Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2682593002: Refactor ContentViewClient (4/6) (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 392db7b22efd445ef65ae90fb3b2a9caad6f73e2..3aee1f069733ad04ce890fb76a84b70a3e27d0a5 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -456,14 +456,6 @@ void ContentViewCoreImpl::UpdateFrameInfo(
insertion_marker_top, insertion_marker_bottom);
}
-void ContentViewCoreImpl::OnBackgroundColorChanged(SkColor color) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (obj.is_null())
- return;
- Java_ContentViewCore_onBackgroundColorChanged(env, obj, color);
-}
-
void ContentViewCoreImpl::ShowSelectPopupMenu(
RenderFrameHost* frame,
const gfx::Rect& bounds,
@@ -653,18 +645,6 @@ void ContentViewCoreImpl::ShowPastePopup(int x_dip, int y_dip) {
y_dip);
}
-void ContentViewCoreImpl::StartContentIntent(const GURL& content_url,
- bool is_main_frame) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
- if (j_obj.is_null())
- return;
- ScopedJavaLocalRef<jstring> jcontent_url =
- ConvertUTF8ToJavaString(env, content_url.spec());
- Java_ContentViewCore_startContentIntent(env, j_obj, jcontent_url,
- is_main_frame);
-}
-
void ContentViewCoreImpl::ShowDisambiguationPopup(
const gfx::Rect& rect_pixels,
const SkBitmap& zoomed_bitmap) {

Powered by Google App Engine
This is Rietveld 408576698