Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/browser/search_engines/template_url_service_sync_unittest.cc

Issue 2682453002: Changed keywords conflicts resolution for extensions search engines. (Closed)
Patch Set: Updated after review, round 3 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_sync_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_sync_unittest.cc b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
index 68ad9f8f5c2e39977cc2fe3c769b7f13bb8d6a42..0e2d7d2ba1f02b7d299dbbb88621a19b8cceb9d3 100644
--- a/chrome/browser/search_engines/template_url_service_sync_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
@@ -418,7 +418,8 @@ TEST_F(TemplateURLServiceSyncTest, GetAllSyncDataWithExtension) {
model()->Add(CreateTestTemplateURL(ASCIIToUTF16("key2"), "http://key2.com"));
std::string fake_id("blahblahblah");
std::string fake_url = std::string(kOmniboxScheme) + "://" + fake_id;
- model()->RegisterOmniboxKeyword(fake_id, "unittest", "key3", fake_url);
+ model()->RegisterOmniboxKeyword(fake_id, "unittest", "key3", fake_url,
+ base::Time::Now());
syncer::SyncDataList all_sync_data =
model()->GetAllSyncData(syncer::SEARCH_ENGINES);
@@ -1076,14 +1077,14 @@ TEST_F(TemplateURLServiceSyncTest, ProcessChangesWithLocalExtensions) {
// Add some extension keywords locally.
model()->RegisterOmniboxKeyword("extension1", "unittest", "keyword1",
- "http://extension1");
+ "http://extension1", base::Time::Now());
TemplateURL* extension1 =
model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword1"));
ASSERT_TRUE(extension1);
EXPECT_EQ(0U, processor()->change_list_size());
model()->RegisterOmniboxKeyword("extension2", "unittest", "keyword2",
- "http://extension2");
+ "http://extension2", base::Time::Now());
TemplateURL* extension2 =
model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword2"));
ASSERT_TRUE(extension2);
@@ -1099,17 +1100,11 @@ TEST_F(TemplateURLServiceSyncTest, ProcessChangesWithLocalExtensions) {
CreateTestTemplateURL(ASCIIToUTF16("keyword2"), "http://bbb.com")));
model()->ProcessSyncChanges(FROM_HERE, changes);
- EXPECT_FALSE(model()->GetTemplateURLForHost("aaa.com") == NULL);
+ EXPECT_TRUE(model()->GetTemplateURLForHost("aaa.com"));
+ EXPECT_TRUE(model()->GetTemplateURLForHost("bbb.com"));
EXPECT_EQ(extension1,
model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword1")));
- TemplateURL* url_for_keyword2 =
- model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword2"));
- EXPECT_NE(extension2, url_for_keyword2);
- EXPECT_EQ("http://bbb.com", url_for_keyword2->url());
-
- EXPECT_EQ(extension1,
- model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword1")));
- EXPECT_EQ(model()->GetTemplateURLForHost("bbb.com"),
+ EXPECT_EQ(extension2,
model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword2")));
}

Powered by Google App Engine
This is Rietveld 408576698