Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4462)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 2682453002: Changed keywords conflicts resolution for extensions search engines. (Closed)
Patch Set: Updated after review, round 3 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc
index d954ed0be435dbf8b36cc135f25ec4d0c7b2dac2..a4c0a2919068081b3b490062d4e61cd577dd1d08 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc
+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc
@@ -219,7 +219,8 @@ void OmniboxAPI::OnExtensionLoaded(content::BrowserContext* browser_context,
if (url_service_->loaded()) {
url_service_->RegisterOmniboxKeyword(
extension->id(), extension->name(), keyword,
- GetTemplateURLStringForExtension(extension->id()));
+ GetTemplateURLStringForExtension(extension->id()),
+ ExtensionPrefs::Get(profile_)->GetInstallTime(extension->id()));
} else {
pending_extensions_.insert(extension);
}
@@ -247,11 +248,11 @@ gfx::Image OmniboxAPI::GetOmniboxIcon(const std::string& extension_id) {
void OmniboxAPI::OnTemplateURLsLoaded() {
// Register keywords for pending extensions.
template_url_sub_.reset();
- for (PendingExtensions::const_iterator i(pending_extensions_.begin());
- i != pending_extensions_.end(); ++i) {
+ for (const auto i : pending_extensions_) {
url_service_->RegisterOmniboxKeyword(
- (*i)->id(), (*i)->name(), OmniboxInfo::GetKeyword(*i),
- GetTemplateURLStringForExtension((*i)->id()));
+ i->id(), i->name(), OmniboxInfo::GetKeyword(i),
+ GetTemplateURLStringForExtension(i->id()),
+ ExtensionPrefs::Get(profile_)->GetInstallTime(i->id()));
}
pending_extensions_.clear();
}

Powered by Google App Engine
This is Rietveld 408576698