[MD settings] change menu and domain icons

[MD settings] change menu and domain icons

This CL changes the menu and domain icons to match the chromeos versions
of those icons. This CL also corrects a centering issue with the domain
icons.

BUG=690318, 636231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682423002
Cr-Commit-Position: refs/heads/master@{#450085}
Committed: https://chromium.googlesource.com/chromium/src/+/1a816bf16dc21e89afc43222a23901fb2b1a32ae

[dschuyler, 2017-02-09 22:48:54]

Description was changed from

==========
[MD settings] change menu and domain icons

This CL changes the menu and domain icons to match the chromeos versions
of those icons. This CL also corrects a centering issue with the domain
icons.

BUG=690318, 636231
==========

to

==========
[MD settings] change menu and domain icons

This CL changes the menu and domain icons to match the chromeos versions
of those icons. This CL also corrects a centering issue with the domain
icons.

BUG=690318, 636231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-02-09 22:48:56]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 22:49:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-09 22:52:14]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-02-09 22:52:30]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-09 22:53:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 23:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 23:47:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2017-02-10 00:41:15]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 00:41:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:17:20]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-02-10 22:18:28]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2017-02-10 22:24:23]

lgtm thanks!

https://codereview.chromium.org/2682423002/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/icons.html (right):

https://codereview.chromium.org/2682423002/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/icons.html:9: <iron-iconset-svg name="cr20"
size="20">
I think it be good to add a comment explaining why we have separate 20px icons
(because the 24 px icons look bad when scaled down -- and we scale all of them
down to 20px right?)

[dschuyler, 2017-02-11 01:02:07]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 01:02:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-11 01:02:46]

https://codereview.chromium.org/2682423002/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/icons.html (right):

https://codereview.chromium.org/2682423002/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/icons.html:9: <iron-iconset-svg name="cr20"
size="20">
On 2017/02/10 22:24:22, tommycli wrote:
> I think it be good to add a comment explaining why we have separate 20px icons
> (because the 24 px icons look bad when scaled down -- and we scale all of them
> down to 20px right?)

Done.

[commit-bot: I haz the power, 2017-02-11 02:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 02:16:09]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-02-13 19:27:19]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2017-02-13 19:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2682423002/#ps60001
(title: "updated comment")

[commit-bot: I haz the power, 2017-02-13 19:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 21:06:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487014039401450,
"parent_rev": "957939675c16e545998a0e707162d296894ae16a", "commit_rev":
"1a816bf16dc21e89afc43222a23901fb2b1a32ae"}

[commit-bot: I haz the power, 2017-02-13 21:07:11]

Description was changed from

==========
[MD settings] change menu and domain icons

This CL changes the menu and domain icons to match the chromeos versions
of those icons. This CL also corrects a centering issue with the domain
icons.

BUG=690318, 636231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] change menu and domain icons

This CL changes the menu and domain icons to match the chromeos versions
of those icons. This CL also corrects a centering issue with the domain
icons.

BUG=690318, 636231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682423002
Cr-Commit-Position: refs/heads/master@{#450085}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a816bf16dc21e89afc43222a239...
==========

[commit-bot: I haz the power, 2017-02-13 21:07:12]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1a816bf16dc21e89afc43222a239...