Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: slave/skia_slave_scripts/run_decoding_tests.py

Issue 26824003: Write skimage results to full builder_name. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot
Patch Set: Respond to comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/run_decoding_tests.py
diff --git a/slave/skia_slave_scripts/run_decoding_tests.py b/slave/skia_slave_scripts/run_decoding_tests.py
index 9f0468ed4d642b36a5f82746c89df474ee649d9b..fb81ce53a2e1775ed71c6fd37954659e02b80a14 100644
--- a/slave/skia_slave_scripts/run_decoding_tests.py
+++ b/slave/skia_slave_scripts/run_decoding_tests.py
@@ -16,11 +16,11 @@ class RunDecodingTests(BuildStep):
def _Run(self):
cmd = ['-r', self._device_dirs.SKImageInDir(), '--noreencode']
- subdir = builder_name_schema.GetWaterfallBot(self._builder_name)
-
# Read expectations, which were downloaded/copied to the device.
+ # If this bot is a trybot, read the expected results of the waterfall bot.
expectations_file = self._flavor_utils.DevicePathJoin(
- self._device_dirs.SKImageExpectedDir(), subdir,
+ self._device_dirs.SKImageExpectedDir(),
+ builder_name_schema.GetWaterfallBot(self._builder_name),
GM_EXPECTATIONS_FILENAME)
have_expectations = self._flavor_utils.DevicePathExists(expectations_file)
@@ -29,7 +29,7 @@ class RunDecodingTests(BuildStep):
# Write the expectations file, in case any did not match.
device_subdir = self._flavor_utils.DevicePathJoin(
- self._device_dirs.SKImageOutDir(), subdir)
+ self._device_dirs.SKImageOutDir(), self._builder_name)
self._flavor_utils.CreateCleanDeviceDirectory(device_subdir)
output_expectations_file = self._flavor_utils.DevicePathJoin(
device_subdir, run_gm.JSON_SUMMARY_FILENAME)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698