Change MessageLoop type for GPU tests with Ozone.

Change MessageLoop type for GPU tests with Ozone.

Some Ozone platforms require a specific MessageLoop type in the GPU.
Namely, this is Ozone X11 that depends on libevent which in turn needs
TYPE_UI message loop to get XEvents.

When initializing the GPU process we check
OzonePlatform::GetMessageLoopTypeForGPU() to get the message loop type.
Do something similar for gpu_unittets and gpu_ipc_service_unittests so
that they can pass with Ozone X11.

Those tests will still run by default with Ozone headless on
linux_chromium_chromeos_ozone_rel_ng. This can be changed later if the
tests appear stable on an FYI bot with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2682393003
Cr-Commit-Position: refs/heads/master@{#453602}
Committed: https://chromium.googlesource.com/chromium/src/+/ffae7e0a3390a6f07620f47f95d5d00a0a887f66

[kylechar, 2017-02-09 21:29:17]

Description was changed from

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform. This fixes GPU relates tests with
Ozone X11, so switch platform from headless to x11.

BUG=686092
==========

to

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform. This fixes GPU relates tests with
Ozone X11, so switch platform from headless to x11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-02-09 21:29:47]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 21:30:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 22:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 22:30:42]

Dry run: This issue passed the CQ dry run.

[fwang, 2017-02-13 08:23:18]

Description was changed from

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform. This fixes GPU relates tests with
Ozone X11, so switch platform from headless to x11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform. This fixes GPU relates tests with
Ozone X11, so switch platform from headless to x11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-02-24 21:46:54]

Description was changed from

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform. This fixes GPU relates tests with
Ozone X11, so switch platform from headless to x11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-02-24 21:47:40]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:48:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:53:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[kylechar, 2017-02-24 21:53:59]

Description was changed from

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform. This will allow running
gpu_unittests and gpu_ipc_service_unittests with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-02-24 22:00:29]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 22:01:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 23:41:56]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-02-27 15:55:12]

Description was changed from

==========
Change MessageLoop type for Ozone GPU tests.

Ozone X11 requires a TYPE_UI MessageLoop. If USE_OZONE then get the
MessageLoop type from OzonePlatform. This will allow running
gpu_unittests and gpu_ipc_service_unittests with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change MessageLoop type for GPU tests with Ozone.

Some Ozone platforms require a specific MessageLoop type in the GPU.
Namely, this is Ozone X11 that depends on libevent which in turn needs
TYPE_UI message loop to get XEvents.

When initializing the GPU process we check
OzonePlatform::GetMessageLoopTypeForGPU() to get the message loop type.
Do something similar for gpu_unittets and gpu_ipc_service_unittests so
that they can pass with Ozone X11.

Those tests will still run by default with Ozone headless on
linux_chromium_chromeos_ozone_rel_ng. This can be changed later if the
tests appear stable on an FYI bot with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-02-27 15:55:42]

Description was changed from

==========
Change MessageLoop type for GPU tests with Ozone.

Some Ozone platforms require a specific MessageLoop type in the GPU.
Namely, this is Ozone X11 that depends on libevent which in turn needs
TYPE_UI message loop to get XEvents.

When initializing the GPU process we check
OzonePlatform::GetMessageLoopTypeForGPU() to get the message loop type.
Do something similar for gpu_unittets and gpu_ipc_service_unittests so
that they can pass with Ozone X11.

Those tests will still run by default with Ozone headless on
linux_chromium_chromeos_ozone_rel_ng. This can be changed later if the
tests appear stable on an FYI bot with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change MessageLoop type for GPU tests with Ozone.

Some Ozone platforms require a specific MessageLoop type in the GPU.
Namely, this is Ozone X11 that depends on libevent which in turn needs
TYPE_UI message loop to get XEvents.

When initializing the GPU process we check
OzonePlatform::GetMessageLoopTypeForGPU() to get the message loop type.
Do something similar for gpu_unittets and gpu_ipc_service_unittests so
that they can pass with Ozone X11.

Those tests will still run by default with Ozone headless on
linux_chromium_chromeos_ozone_rel_ng. This can be changed later if the
tests appear stable on an FYI bot with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-02-27 16:09:20]

kylechar@chromium.org changed reviewers:
+ kbr@chromium.org

[tonikitoo, 2017-02-27 16:49:32]

On 2017/02/27 16:09:21, kylechar wrote:

informal l g t m

[Ken Russell (switch to Gerrit), 2017-02-28 05:34:11]

lgtm

+fjhenigman as FYI

[kylechar, 2017-02-28 13:44:12]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 13:44:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-02-28 13:44:28]

Thanks kbr!

[kylechar, 2017-02-28 15:04:50]

The CQ bit was unchecked by kylechar@chromium.org

[kylechar, 2017-02-28 15:04:50]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-02-28 15:05:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 15:09:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488294290516910,
"parent_rev": "479d235a0b03635db869561392763957cfdcb20b", "commit_rev":
"ffae7e0a3390a6f07620f47f95d5d00a0a887f66"}

[commit-bot: I haz the power, 2017-02-28 15:10:19]

Description was changed from

==========
Change MessageLoop type for GPU tests with Ozone.

Some Ozone platforms require a specific MessageLoop type in the GPU.
Namely, this is Ozone X11 that depends on libevent which in turn needs
TYPE_UI message loop to get XEvents.

When initializing the GPU process we check
OzonePlatform::GetMessageLoopTypeForGPU() to get the message loop type.
Do something similar for gpu_unittets and gpu_ipc_service_unittests so
that they can pass with Ozone X11.

Those tests will still run by default with Ozone headless on
linux_chromium_chromeos_ozone_rel_ng. This can be changed later if the
tests appear stable on an FYI bot with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change MessageLoop type for GPU tests with Ozone.

Some Ozone platforms require a specific MessageLoop type in the GPU.
Namely, this is Ozone X11 that depends on libevent which in turn needs
TYPE_UI message loop to get XEvents.

When initializing the GPU process we check
OzonePlatform::GetMessageLoopTypeForGPU() to get the message loop type.
Do something similar for gpu_unittets and gpu_ipc_service_unittests so
that they can pass with Ozone X11.

Those tests will still run by default with Ozone headless on
linux_chromium_chromeos_ozone_rel_ng. This can be changed later if the
tests appear stable on an FYI bot with Ozone X11.

BUG=686092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2682393003
Cr-Commit-Position: refs/heads/master@{#453602}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffae7e0a3390a6f07620f47f95d5...
==========

[commit-bot: I haz the power, 2017-02-28 15:10:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ffae7e0a3390a6f07620f47f95d5...