Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2682223005:
Fix nullptr dereference in thread-safe Channel forwarding (Closed)
|
Created:
3 years, 10 months ago by Ken Rockot(use gerrit already) Modified:
3 years, 10 months ago Reviewers:
yzshen1 CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix nullptr dereference in thread-safe Channel forwarding
It's possible to hit IPc::ChannelMojo::ForwardMessage* while
the MessagePipeReader is still alive but has closed its sender
binding. This fixes that.
BUG=690493
TEST=content_browsertests with ASAN
Review-Url: https://codereview.chromium.org/2682223005
Cr-Commit-Position: refs/heads/master@{#449413}
Committed: https://chromium.googlesource.com/chromium/src/+/67b4b0c5317c2a8e30e141540697200094b9bff3
Patch Set 1 : . #Patch Set 2 : . #Messages
Total messages: 22 (18 generated)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Description was changed from ========== Fix nullptr dereference in thread-safe Channel forwarding It's possible to hit IPc::ChannelMojo::ForwardMessage* while the MessagePipeReader is still alive but has closed its sender binding. This fixes that. BUG=690493 ========== to ========== Fix nullptr dereference in thread-safe Channel forwarding It's possible to hit IPc::ChannelMojo::ForwardMessage* while the MessagePipeReader is still alive but has closed its sender binding. This fixes that. BUG=690493 TEST=content_browsertests with ASAN ==========
rockot@chromium.org changed reviewers: + yzshen@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rockot@chromium.org
The CQ bit was checked by rockot@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org Link to the patchset: https://codereview.chromium.org/2682223005/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486672327429550,
"parent_rev": "a85730c84d15b89b04bf58ed6efda2050c9de619", "commit_rev":
"67b4b0c5317c2a8e30e141540697200094b9bff3"}
Message was sent while issue was closed.
Description was changed from ========== Fix nullptr dereference in thread-safe Channel forwarding It's possible to hit IPc::ChannelMojo::ForwardMessage* while the MessagePipeReader is still alive but has closed its sender binding. This fixes that. BUG=690493 TEST=content_browsertests with ASAN ========== to ========== Fix nullptr dereference in thread-safe Channel forwarding It's possible to hit IPc::ChannelMojo::ForwardMessage* while the MessagePipeReader is still alive but has closed its sender binding. This fixes that. BUG=690493 TEST=content_browsertests with ASAN Review-Url: https://codereview.chromium.org/2682223005 Cr-Commit-Position: refs/heads/master@{#449413} Committed: https://chromium.googlesource.com/chromium/src/+/67b4b0c5317c2a8e30e141540697... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/67b4b0c5317c2a8e30e141540697... |
