Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: content/browser/frame_host/interstitial_page_navigator_impl.cc

Issue 2682193002: Convert NavigationController unit and browser tests to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_navigator_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_navigator_impl.cc b/content/browser/frame_host/interstitial_page_navigator_impl.cc
index f0156988a3d5ca266c11b52181a9bb9607fa0aa3..c67156593ad29c426e4fc0d01a7356d1881f0e57 100644
--- a/content/browser/frame_host/interstitial_page_navigator_impl.cc
+++ b/content/browser/frame_host/interstitial_page_navigator_impl.cc
@@ -50,6 +50,7 @@ void InterstitialPageNavigatorImpl::DidNavigate(
const FrameHostMsg_DidCommitProvisionalLoad_Params& input_params,
std::unique_ptr<NavigationHandleImpl> navigation_handle) {
navigation_handle->DidCommitNavigation(input_params, false, GURL(),
+ NAVIGATION_TYPE_UNKNOWN,
nasko 2017/02/09 00:29:11 Interstitials navigate to a new page, so it seems
jam 2017/02/09 01:15:03 Done.
render_frame_host);
navigation_handle.reset();

Powered by Google App Engine
This is Rietveld 408576698