Android: Replace symlinks with gradle filters

Android: Replace symlinks with gradle filters

Use filters to exclude unwanted files from source directories instead of
creating symlink dirs for android studio gradle scripts.

Paves the way for multiple modules including the same source dirs.

BUG=690073
Review-Url: https://codereview.chromium.org/2682183002
Cr-Commit-Position: refs/heads/master@{#449301}
Committed: https://chromium.googlesource.com/chromium/src/+/9032b352ce46f107da00bf7b00ece989d86dcfb5

[Peter Wen, 2017-02-08 20:58:15]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[Peter Wen, 2017-02-08 20:58:47]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[Peter Wen, 2017-02-08 20:58:47]

PTAL, step towards single apk project/modules.

[commit-bot: I haz the power, 2017-02-08 20:59:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2017-02-09 10:00:38]

lgtm

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:325: logging.debug('Target requires
.java symlinks: %s, %s',
nit: update log message to not say symlinks

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:327: # Shorten exclude list by globbing
if possible.
Might be worth pulling this out into a helper function. I found it a bit hard to
follow with it nested here and doing very similar looking things.

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:338: unwanted_java_files -=
set(found_files)
you convert found_files to a set twice. Maybe just declare it as one in the
glob() line?

[Peter Wen, 2017-02-09 14:37:48]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 14:38:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-02-09 14:38:29]

Thanks for the review! I'm learning a lot about python style. :)

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:325: logging.debug('Target requires
.java symlinks: %s, %s',
On 2017/02/09 10:00:38, agrieve wrote:
> nit: update log message to not say symlinks

Done.

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:327: # Shorten exclude list by globbing
if possible.
On 2017/02/09 10:00:38, agrieve wrote:
> Might be worth pulling this out into a helper function. I found it a bit hard
to
> follow with it nested here and doing very similar looking things.

Done.

https://codereview.chromium.org/2682183002/diff/40001/build/android/gradle/ge...
build/android/gradle/generate_gradle.py:338: unwanted_java_files -=
set(found_files)
On 2017/02/09 10:00:38, agrieve wrote:
> you convert found_files to a set twice. Maybe just declare it as one in the
> glob() line?

Done.

[commit-bot: I haz the power, 2017-02-09 15:36:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 15:36:19]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2017-02-09 15:49:22]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-02-09 15:49:22]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2682183002/#ps60001
(title: "Fix per review")

[commit-bot: I haz the power, 2017-02-09 15:49:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 15:53:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486655362035680,
"parent_rev": "2b6190ce82fd0c4bde7dc90a5c81900536b273fa", "commit_rev":
"9032b352ce46f107da00bf7b00ece989d86dcfb5"}

[commit-bot: I haz the power, 2017-02-09 15:54:11]

Description was changed from

==========
Android: Replace symlinks with gradle filters

Use filters to exclude unwanted files from source directories instead of
creating symlink dirs for android studio gradle scripts.

Paves the way for multiple modules including the same source dirs.

BUG=690073
==========

to

==========
Android: Replace symlinks with gradle filters

Use filters to exclude unwanted files from source directories instead of
creating symlink dirs for android studio gradle scripts.

Paves the way for multiple modules including the same source dirs.

BUG=690073

Review-Url: https://codereview.chromium.org/2682183002
Cr-Commit-Position: refs/heads/master@{#449301}
Committed:
https://chromium.googlesource.com/chromium/src/+/9032b352ce46f107da00bf7b00ec...
==========

[commit-bot: I haz the power, 2017-02-09 15:54:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9032b352ce46f107da00bf7b00ec...