Heuristic for eager parsing works for async functions

Heuristic for eager parsing works for async functions

The heuristic checks for "(function", and now it also checks for
"(async function".

BUG=v8:4230
Review-Url: https://codereview.chromium.org/2682173005
Cr-Commit-Position: refs/heads/master@{#43120}
Committed: https://chromium.googlesource.com/v8/v8/+/9675811a60abd9e2f7d33a3374f950bb85d238d9

[jwolfe, 2017-02-09 21:08:08]

Description was changed from

==========
Heuristic for eager parsing works for async functions

The heuristic checks for "(function", and now it also checks for
"(async function".

BUG=v8:4230
==========

to

==========
Heuristic for eager parsing works for async functions

The heuristic checks for "(function", and now it also checks for
"(async function".

BUG=v8:4230
==========

[jwolfe, 2017-02-09 21:08:08]

jwolfe@igalia.com changed reviewers:
+ caitp@igalia.com, littledan@chromium.org

[jwolfe, 2017-02-09 21:09:42]

PTAL.

The change to the test status might be a bit misleading. We're not actually
catching the early error; we're running the parser instead of the preparser. If
the test used a "0, " prefix before the "async function" instead of a "("
prefix, then we'd fail the test again.

[caitp, 2017-02-09 21:15:46]

On 2017/02/09 21:09:42, jwolfe wrote:
> PTAL.
> 
> The change to the test status might be a bit misleading. We're not actually
> catching the early error; we're running the parser instead of the preparser.
If
> the test used a "0, " prefix before the "async function" instead of a "("
> prefix, then we'd fail the test again.

Looks fine to me.

[Dan Ehrenberg, 2017-02-10 08:17:28]

littledan@chromium.org changed reviewers:
+ marja@chromium.org

[Dan Ehrenberg, 2017-02-10 08:17:29]

lgtm

LGTM, but adding Marja as a reviewer for more parser expertise; please wait for
another review before committing.

[marja, 2017-02-10 08:26:29]

lgtm

[jwolfe, 2017-02-10 20:32:02]

The CQ bit was checked by jwolfe@igalia.com

[commit-bot: I haz the power, 2017-02-10 20:32:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 20:55:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486758722143530, "parent_rev":
"21523c7832cdbd74fceacddf4660977eef02cd4c", "commit_rev":
"9675811a60abd9e2f7d33a3374f950bb85d238d9"}

[commit-bot: I haz the power, 2017-02-10 20:56:03]

Description was changed from

==========
Heuristic for eager parsing works for async functions

The heuristic checks for "(function", and now it also checks for
"(async function".

BUG=v8:4230
==========

to

==========
Heuristic for eager parsing works for async functions

The heuristic checks for "(function", and now it also checks for
"(async function".

BUG=v8:4230

Review-Url: https://codereview.chromium.org/2682173005
Cr-Commit-Position: refs/heads/master@{#43120}
Committed:
https://chromium.googlesource.com/v8/v8/+/9675811a60abd9e2f7d33a3374f950bb85d...
==========

[commit-bot: I haz the power, 2017-02-10 20:56:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9675811a60abd9e2f7d33a3374f950bb85d...