Fix COMPONENTS entry for extensions/api/web_view/OWNERS.

Fix COMPONENTS entry for extensions/api/web_view/OWNERS.

BUG=679905
Review-Url: https://codereview.chromium.org/2682173002
Cr-Commit-Position: refs/heads/master@{#449705}
Committed: https://chromium.googlesource.com/chromium/src/+/98e40547c25195c145bf19c9272ca50e88db4d43

[lazyboy, 2017-02-08 20:35:49]

lazyboy@chromium.org changed reviewers:
+ ymzhang@chromium.org

[lazyboy, 2017-02-08 20:36:01]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 20:37:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:01:03]

Dry run: This issue passed the CQ dry run.

[ymzhang1, 2017-02-09 23:51:44]

lgtm

[lazyboy, 2017-02-10 00:05:06]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:05:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 00:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:05:44]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[lazyboy, 2017-02-10 00:12:01]

lazyboy@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[lazyboy, 2017-02-10 00:12:02]

+James for your rubberstamp, thanks.

[wjmaclean, 2017-02-10 14:33:54]

LGTM

It would be nice if we could somehow create a "WebView" alias for "Browsertag",
since we routinely use the term "WebView" when talking about the project. Not
sure if COMPONENTS has a notion of 'equivalence' like that though ...

[lazyboy, 2017-02-10 18:11:34]

On 2017/02/10 14:33:54, wjmaclean wrote:
> LGTM
> 
> It would be nice if we could somehow create a "WebView" alias for
"Browsertag",
> since we routinely use the term "WebView" when talking about the project. Not
> sure if COMPONENTS has a notion of 'equivalence' like that though ...

Good point, maybe ymzhang1@ knows?

[ymzhang1, 2017-02-10 18:26:50]

On 2017/02/10 18:11:34, lazyboy wrote:
> On 2017/02/10 14:33:54, wjmaclean wrote:
> > LGTM
> > 
> > It would be nice if we could somehow create a "WebView" alias for
> "Browsertag",
> > since we routinely use the term "WebView" when talking about the project.
Not
> > sure if COMPONENTS has a notion of 'equivalence' like that though ...
> 
> Good point, maybe ymzhang1@ knows?

The only component I found with a "WebView" alias is "Mobile>WebView", which
seems not fit here. 

I checked "Platform>Apps>BrowserTag" on the Monorail, it (=GuestView,
<webview>).

Maybe rename "Platform>Apps>BrowserTag" or create a new component?

[wjmaclean, 2017-02-10 18:29:09]

On 2017/02/10 18:26:50, ymzhang1 wrote:
> On 2017/02/10 18:11:34, lazyboy wrote:
> > On 2017/02/10 14:33:54, wjmaclean wrote:
> > > LGTM
> > > 
> > > It would be nice if we could somehow create a "WebView" alias for
> > "Browsertag",
> > > since we routinely use the term "WebView" when talking about the project.
> Not
> > > sure if COMPONENTS has a notion of 'equivalence' like that though ...
> > 
> > Good point, maybe ymzhang1@ knows?
> 
> The only component I found with a "WebView" alias is "Mobile>WebView", which
> seems not fit here. 
> 
> I checked "Platform>Apps>BrowserTag" on the Monorail, it (=GuestView,
> <webview>).
> 
> Maybe rename "Platform>Apps>BrowserTag" or create a new component?

The only problem with renaming is that a lot of people have gotten use to
calling it BrowserTag, and it *does* differentiate it from Android-WebView (or
Ash WebView, or Blink WebView). That's why I wondered about an alias, at least
so one could search WebView and get BrowserTag hits.

But it's not a big deal if aliases aren't supported ...

[lazyboy, 2017-02-10 19:36:19]

On 2017/02/10 18:29:09, wjmaclean wrote:
> On 2017/02/10 18:26:50, ymzhang1 wrote:
> > On 2017/02/10 18:11:34, lazyboy wrote:
> > > On 2017/02/10 14:33:54, wjmaclean wrote:
> > > > LGTM
> > > > 
> > > > It would be nice if we could somehow create a "WebView" alias for
> > > "Browsertag",
> > > > since we routinely use the term "WebView" when talking about the
project.
> > Not
> > > > sure if COMPONENTS has a notion of 'equivalence' like that though ...
> > > 
> > > Good point, maybe ymzhang1@ knows?
> > 
> > The only component I found with a "WebView" alias is "Mobile>WebView", which
> > seems not fit here. 
> > 
> > I checked "Platform>Apps>BrowserTag" on the Monorail, it (=GuestView,
> > <webview>).
> > 
> > Maybe rename "Platform>Apps>BrowserTag" or create a new component?
> 
> The only problem with renaming is that a lot of people have gotten use to
> calling it BrowserTag, and it *does* differentiate it from Android-WebView (or
> Ash WebView, or Blink WebView). That's why I wondered about an alias, at least
> so one could search WebView and get BrowserTag hits.
> 
> But it's not a big deal if aliases aren't supported ...

BrowserTag is a good label description: "GuestView, <webview>", however
components autofill in crbug.com/new doesn't suggest BrowserTag label if I
type "webview".
Oh well, I'll hit CQ on this one...

[lazyboy, 2017-02-10 19:36:41]

On 2017/02/10 19:36:19, lazyboy wrote:
> On 2017/02/10 18:29:09, wjmaclean wrote:
> > On 2017/02/10 18:26:50, ymzhang1 wrote:
> > > On 2017/02/10 18:11:34, lazyboy wrote:
> > > > On 2017/02/10 14:33:54, wjmaclean wrote:
> > > > > LGTM
> > > > > 
> > > > > It would be nice if we could somehow create a "WebView" alias for
> > > > "Browsertag",
> > > > > since we routinely use the term "WebView" when talking about the
> project.
> > > Not
> > > > > sure if COMPONENTS has a notion of 'equivalence' like that though ...
> > > > 
> > > > Good point, maybe ymzhang1@ knows?
> > > 
> > > The only component I found with a "WebView" alias is "Mobile>WebView",
which
> > > seems not fit here. 
> > > 
> > > I checked "Platform>Apps>BrowserTag" on the Monorail, it (=GuestView,
> > > <webview>).
> > > 
> > > Maybe rename "Platform>Apps>BrowserTag" or create a new component?
> > 
> > The only problem with renaming is that a lot of people have gotten use to
> > calling it BrowserTag, and it *does* differentiate it from Android-WebView
(or
> > Ash WebView, or Blink WebView). That's why I wondered about an alias, at
least
> > so one could search WebView and get BrowserTag hits.
> > 
> > But it's not a big deal if aliases aren't supported ...
> 
> BrowserTag is a good label description: "GuestView, <webview>", however
> components autofill in crbug.com/new doesn't suggest BrowserTag label if I
> type "webview".
> Oh well, I'll hit CQ on this one...

s/is/has

[lazyboy, 2017-02-10 19:36:55]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2017-02-10 19:37:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:53:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486755415507040, "parent_rev":
"f60887063fcf9c142a478a46f3c052c51256d5ca", "commit_rev":
"98e40547c25195c145bf19c9272ca50e88db4d43"}

[commit-bot: I haz the power, 2017-02-10 19:54:01]

Description was changed from

==========
Fix COMPONENTS entry for extensions/api/web_view/OWNERS.

BUG=679905
==========

to

==========
Fix COMPONENTS entry for extensions/api/web_view/OWNERS.

BUG=679905

Review-Url: https://codereview.chromium.org/2682173002
Cr-Commit-Position: refs/heads/master@{#449705}
Committed:
https://chromium.googlesource.com/chromium/src/+/98e40547c25195c145bf19c9272c...
==========

[commit-bot: I haz the power, 2017-02-10 19:54:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98e40547c25195c145bf19c9272c...

[ymzhang1, 2017-02-10 23:41:23]

On 2017/02/10 19:36:41, lazyboy wrote:
> On 2017/02/10 19:36:19, lazyboy wrote:
> > On 2017/02/10 18:29:09, wjmaclean wrote:
> > > On 2017/02/10 18:26:50, ymzhang1 wrote:
> > > > On 2017/02/10 18:11:34, lazyboy wrote:
> > > > > On 2017/02/10 14:33:54, wjmaclean wrote:
> > > > > > LGTM
> > > > > > 
> > > > > > It would be nice if we could somehow create a "WebView" alias for
> > > > > "Browsertag",
> > > > > > since we routinely use the term "WebView" when talking about the
> > project.
> > > > Not
> > > > > > sure if COMPONENTS has a notion of 'equivalence' like that though
...
> > > > > 
> > > > > Good point, maybe ymzhang1@ knows?
> > > > 
> > > > The only component I found with a "WebView" alias is "Mobile>WebView",
> which
> > > > seems not fit here. 
> > > > 
> > > > I checked "Platform>Apps>BrowserTag" on the Monorail, it (=GuestView,
> > > > <webview>).
> > > > 
> > > > Maybe rename "Platform>Apps>BrowserTag" or create a new component?
> > > 
> > > The only problem with renaming is that a lot of people have gotten use to
> > > calling it BrowserTag, and it *does* differentiate it from Android-WebView
> (or
> > > Ash WebView, or Blink WebView). That's why I wondered about an alias, at
> least
> > > so one could search WebView and get BrowserTag hits.
> > > 
> > > But it's not a big deal if aliases aren't supported ...
> > 
> > BrowserTag is a good label description: "GuestView, <webview>", however
> > components autofill in crbug.com/new doesn't suggest BrowserTag label if I
> > type "webview".
> > Oh well, I'll hit CQ on this one...
> 
> s/is/has

I think this might be relevant. (Thanks to Jason Robbins)
https://bugs.chromium.org/p/monorail/issues/detail?id=1297