Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2682153003: [stubs] Port LoadIndexedStringStub to CSA (Closed)

Created:
3 years, 10 months ago by Jakob Kummerow
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Port LoadIndexedStringStub to CSA BUG=v8:5269 Review-Url: https://codereview.chromium.org/2682153003 Cr-Commit-Position: refs/heads/master@{#43071} Committed: https://chromium.googlesource.com/v8/v8/+/63b980f996c86cfcce724e19e576e95af9e5ba31

Patch Set 1 #

Patch Set 2 : delete handwritten version #

Patch Set 3 : move to builtins-handler.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -770 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 chunks +0 lines, -72 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 chunks +0 lines, -65 lines 0 comments Download
M src/bailout-reason.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M src/builtins/builtins-string.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/code-stubs.h View 1 4 chunks +0 lines, -109 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 chunks +0 lines, -80 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 chunks +0 lines, -74 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 chunks +0 lines, -67 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 2 chunks +0 lines, -73 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 2 chunks +0 lines, -69 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 chunks +0 lines, -71 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
PTAL.
3 years, 10 months ago (2017-02-09 02:30:06 UTC) #2
Igor Sheludko
Nice! lgtm
3 years, 10 months ago (2017-02-09 08:04:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682153003/40001
3 years, 10 months ago (2017-02-09 18:49:04 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 18:50:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/63b980f996c86cfcce724e19e576e95af9e...

Powered by Google App Engine
This is Rietveld 408576698