Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2682153002: macOS: Focus first profile (Closed)

Created:
3 years, 10 months ago by jlebel
Modified:
3 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macOS: Focus first profile In crrev.com/2638853003, the last profile in the menu is getting focused. This should have been the first profile. BUG=689889 Review-Url: https://codereview.chromium.org/2682153002 Cr-Commit-Position: refs/heads/master@{#449069} Committed: https://chromium.googlesource.com/chromium/src/+/888b44e14b7afac674d55e305c8dd89a393cbdac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jlebel
Hello Mark, Can you review this patch that fixes a bug I introduced yesterday about ...
3 years, 10 months ago (2017-02-08 16:39:57 UTC) #2
Mark Mentovai
LGTM
3 years, 10 months ago (2017-02-08 19:23:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682153002/1
3 years, 10 months ago (2017-02-08 19:25:58 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 19:54:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/888b44e14b7afac674d55e305c8d...

Powered by Google App Engine
This is Rietveld 408576698