Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2682123002: Set the initial dialog width when the sign-in email confirmation dialog is presented. (Closed)

Created:
3 years, 10 months ago by msarda
Modified:
3 years, 10 months ago
Reviewers:
jlebel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the initial dialog width when the sign-in email confirmation dialog is presented. This CL sets the initial dialog width so that the dialog is correctly centered when it first appers. BUG=689995 Review-Url: https://codereview.chromium.org/2682123002 Cr-Commit-Position: refs/heads/master@{#449025} Committed: https://chromium.googlesource.com/chromium/src/+/739de183ce3b03c365f0e5e47b30e1ea3ec1368a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
msarda
Please take a look.
3 years, 10 months ago (2017-02-08 14:46:39 UTC) #2
jlebel
lgtm
3 years, 10 months ago (2017-02-08 16:09:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682123002/1
3 years, 10 months ago (2017-02-08 16:20:02 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 17:33:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/739de183ce3b03c365f0e5e47b30...

Powered by Google App Engine
This is Rietveld 408576698