Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2682073002: Removing old prefs storage for BudgetManager (Closed)

Created:
3 years, 10 months ago by harkness
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing old prefs storage for BudgetManager Originally, the BudgetManager stored the budget for an origin in the prefs in kBacgkroundBudgetMap. As the data stored became more complicated, it switched to using the BudgetDatabase, which is a LevelDB wrapper. The prefs storage mechanism was deprecated in Chrome 56 and code added to cleanup any stored data there. Now that Chrome 57 has branched, we can remove the cleanup code and any remaining prefs artifacts. BUG=617971 Review-Url: https://codereview.chromium.org/2682073002 Cr-Commit-Position: refs/heads/master@{#449035} Committed: https://chromium.googlesource.com/chromium/src/+/24fb1c0d8ccf3d2ed71d341d925ac337253bfef3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M chrome/browser/budget_service/budget_manager.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/budget_service/budget_manager.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
harkness
3 years, 10 months ago (2017-02-08 11:56:30 UTC) #2
Peter Beverloo
lgtm
3 years, 10 months ago (2017-02-08 12:12:59 UTC) #3
harkness
battre@chromium.org: Please review changes in chrome/browser/prefs/browser_prefs.cc.
3 years, 10 months ago (2017-02-08 12:15:00 UTC) #5
harkness
bauerb@ please take a look at chrome/browser/prefs/browser_prefs.cc. Removing battre@ since he's OOO today and tomorrow.
3 years, 10 months ago (2017-02-08 15:47:32 UTC) #7
Bernhard Bauer
LGTM!
3 years, 10 months ago (2017-02-08 16:49:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682073002/1
3 years, 10 months ago (2017-02-08 16:56:22 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 18:04:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24fb1c0d8ccf3d2ed71d341d925a...

Powered by Google App Engine
This is Rietveld 408576698