Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2682023005: cc: Use compositor context for signal sync token callback. (Closed)

Created:
3 years, 10 months ago by sunnyps
Modified:
3 years, 10 months ago
Reviewers:
vmpstr, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Use compositor context for signal sync token callback. The signal sync token callback is run from an IPC message from the GPU process. IPC messages are received on the thread a context is bound to; for the worker context this is the main thread. This causes a data race and a crash during compositor tear down. Using the compositor context is fine because it is bound to the impl thread, and it's safe to receive tile manager callbacks there. R=ericrk@chromium.org,vmpstr@chromium.org BUG=673434 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2682023005 Cr-Commit-Position: refs/heads/master@{#449792} Committed: https://chromium.googlesource.com/chromium/src/+/31c92fe8317757707c7c910c7d67bc04fb6938be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M cc/raster/gpu_raster_buffer_provider.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sunnyps
ptal
3 years, 10 months ago (2017-02-09 03:50:38 UTC) #3
ericrk
thanks for catching this! LGTM
3 years, 10 months ago (2017-02-09 18:31:28 UTC) #7
vmpstr
lgtm
3 years, 10 months ago (2017-02-09 18:49:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682023005/1
3 years, 10 months ago (2017-02-10 22:08:04 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 23:47:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31c92fe8317757707c7c910c7d67...

Powered by Google App Engine
This is Rietveld 408576698