Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2682023002: [MD settings] allow site exceptions without pattern wildcard (Closed)

Created:
3 years, 10 months ago by dschuyler
Modified:
3 years, 10 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, msramek
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] allow site exceptions without pattern wildcard This CL removes the automatic addition of a '[*.]' prefix when entering content site exceptions. So if the user entered 'google.com' it was automatically being promoted to '[*.]google.com'. This CL removes that automatic promotion/alteration of what user entered. BUG=685949 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2682023002 Cr-Commit-Position: refs/heads/master@{#449112} Committed: https://chromium.googlesource.com/chromium/src/+/280885a8ab97723e5f1c4bb6f9fdb1bda1418b2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M chrome/browser/resources/settings/site_settings/add_site_dialog.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_behavior.js View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 10 months ago (2017-02-08 01:40:15 UTC) #4
tommycli
lgtm
3 years, 10 months ago (2017-02-08 22:22:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682023002/1
3 years, 10 months ago (2017-02-08 22:27:52 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 22:35:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/280885a8ab97723e5f1c4bb6f9fd...

Powered by Google App Engine
This is Rietveld 408576698