Chromium Code Reviews
DescriptionRevert of media: Add "Hide players" button in about://media-internals (patchset #2 id:20001 of https://codereview.chromium.org/2672193003/ )
Reason for revert:
Two following tests fail:
-
WebUIResourceBrowserTest.MediaInternals_Integration
- WebUIResourceBrowserTest.MediaInternals_Manager
Original issue's description:
> media: Add "Hide players" button in about://media-internals
>
> What this does is:
> - Adds a button to hide all current players on the page, but doesn't touch the C++ side to actually delete those players.
> - After a player is hidden, new logs for that player will be dropped and will not resurrect any hidden players.
> - If a user refreshes the media-internals page, or open a new one, we'll get all players back.
>
> BUG=688607
>
> Review-Url: https://codereview.chromium.org/2672193003
> Cr-Commit-Position: refs/heads/master@{#448764}
> Committed: https://chromium.googlesource.com/chromium/src/+/4ee2eeb27fb5cb49b1d5fa470528c16738d0274d
TBR=sandersd@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=688607
Review-Url: https://codereview.chromium.org/2682013002
Cr-Commit-Position: refs/heads/master@{#448838}
Committed: https://chromium.googlesource.com/chromium/src/+/eb328e2bf72447674d553e61c948c1462c07c753
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||