Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2682013002: Revert of media: Add "Hide players" button in about://media-internals (Closed)

Created:
3 years, 10 months ago by shimazu
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org, wolenetz, watk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Add "Hide players" button in about://media-internals (patchset #2 id:20001 of https://codereview.chromium.org/2672193003/ ) Reason for revert: Two following tests fail: - WebUIResourceBrowserTest.MediaInternals_Integration - WebUIResourceBrowserTest.MediaInternals_Manager Original issue's description: > media: Add "Hide players" button in about://media-internals > > What this does is: > - Adds a button to hide all current players on the page, but doesn't touch the C++ side to actually delete those players. > - After a player is hidden, new logs for that player will be dropped and will not resurrect any hidden players. > - If a user refreshes the media-internals page, or open a new one, we'll get all players back. > > BUG=688607 > > Review-Url: https://codereview.chromium.org/2672193003 > Cr-Commit-Position: refs/heads/master@{#448764} > Committed: https://chromium.googlesource.com/chromium/src/+/4ee2eeb27fb5cb49b1d5fa470528c16738d0274d TBR=sandersd@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688607 Review-Url: https://codereview.chromium.org/2682013002 Cr-Commit-Position: refs/heads/master@{#448838} Committed: https://chromium.googlesource.com/chromium/src/+/eb328e2bf72447674d553e61c948c1462c07c753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M content/browser/resources/media/manager.js View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/resources/media/media_internals.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
shimazu
Created Revert of media: Add "Hide players" button in about://media-internals
3 years, 10 months ago (2017-02-08 01:31:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682013002/1
3 years, 10 months ago (2017-02-08 01:31:54 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 01:35:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb328e2bf72447674d553e61c948...

Powered by Google App Engine
This is Rietveld 408576698