Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2681993003: [wasm] Accept version 0x1 binaries. (Closed)

Created:
3 years, 10 months ago by titzer
Modified:
3 years, 10 months ago
Reviewers:
bradnelson, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add new expected outputs for inspector tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -63 lines) Patch
M src/wasm/module-decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/inspector/debugger/wasm-get-breakable-locations-expected.txt View 1 2 chunks +24 lines, -24 lines 0 comments Download
M test/inspector/debugger/wasm-scripts-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/inspector/debugger/wasm-stepping-expected.txt View 1 2 chunks +29 lines, -29 lines 0 comments Download
M test/mjsunit/wasm/incrementer.wasm View Binary file 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
titzer
3 years, 10 months ago (2017-02-08 23:21:33 UTC) #1
bradnelson
lgtm but probably should add a second bug line for a bug describing why we'll ...
3 years, 10 months ago (2017-02-09 01:21:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681993003/20001
3 years, 10 months ago (2017-02-09 02:08:08 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 02:09:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fa7d1f8f75e340d917831ef74f401154b0a...

Powered by Google App Engine
This is Rietveld 408576698