Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2681973002:
Add config for ios-simulator-eg on chromium.mac (Closed)
DescriptionAdd config for ios-simulator-eg on chromium.mac
This is for the new try bot that runs EarlGrey tests to mirror.
BUG=689080
Review-Url: https://codereview.chromium.org/2681973002
Cr-Commit-Position: refs/heads/master@{#448895}
Committed: https://chromium.googlesource.com/chromium/src/+/e692b9e03d389ce076f3a57e27e47dfe8db9f4e6
Patch Set 1 #
Total comments: 2
Messages
Total messages: 22 (10 generated)
smut@google.com changed reviewers: + baxley@chromium.org
Just copied from chromium.fyi/EarlGreyiOS.json
I want to check if this creates optional trybots, or also adds it to the main waterfall. I don't think our eg tests are something that should be reviewed by Chromium sheriffs, yet. https://codereview.chromium.org/2681973002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2681973002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:305: 'ios-simulator-eg': 'ios', Sorry for my ignorance, but does this add it to chromium.mac, and put it on the main waterfall? or is this simply a requirement to make it a tryjob? If it's the latter, then I think it's fine. I don't think the EG tests are ready yet to be "main waterfall" tests yet.
I'm just setting up a try bot right now, but allowing for a main waterfall bot to be set up in the future. https://codereview.chromium.org/2681973002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2681973002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:305: 'ios-simulator-eg': 'ios', On 2017/02/08 00:14:53, baxley wrote: > Sorry for my ignorance, but does this add it to chromium.mac, and put it on the > main waterfall? or is this simply a requirement to make it a tryjob? > > If it's the latter, then I think it's fine. I don't think the EG tests are ready > yet to be "main waterfall" tests yet. It doesn't actually put it on the main waterfall, it just lets mb work if/when it ever goes on the main waterfall.
On 2017/02/08 00:21:18, smut wrote: > I'm just setting up a try bot right now, but allowing for a main waterfall bot > to be set up in the future. > > https://codereview.chromium.org/2681973002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2681973002/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:305: 'ios-simulator-eg': 'ios', > On 2017/02/08 00:14:53, baxley wrote: > > Sorry for my ignorance, but does this add it to chromium.mac, and put it on > the > > main waterfall? or is this simply a requirement to make it a tryjob? > > > > If it's the latter, then I think it's fine. I don't think the EG tests are > ready > > yet to be "main waterfall" tests yet. > > It doesn't actually put it on the main waterfall, it just lets mb work if/when > it ever goes on the main waterfall. Awesome! Thank you for the explanation. LGTM
The CQ bit was checked by smut@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by smut@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
smut@google.com changed reviewers: + dpranke@google.com
+dpranke for tools/mb OWNERS
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by smut@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486516616058870, "parent_rev":
"ef194a5caade9022073018afddeb30e8fd9f16ef", "commit_rev":
"e692b9e03d389ce076f3a57e27e47dfe8db9f4e6"}
Message was sent while issue was closed.
Description was changed from ========== Add config for ios-simulator-eg on chromium.mac This is for the new try bot that runs EarlGrey tests to mirror. BUG=689080 ========== to ========== Add config for ios-simulator-eg on chromium.mac This is for the new try bot that runs EarlGrey tests to mirror. BUG=689080 Review-Url: https://codereview.chromium.org/2681973002 Cr-Commit-Position: refs/heads/master@{#448895} Committed: https://chromium.googlesource.com/chromium/src/+/e692b9e03d389ce076f3a57e27e4... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e692b9e03d389ce076f3a57e27e4... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
