Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2681963002:
Remove non-MD test coverage from TrayDetailsViewTest (Closed)
|
Created:
3 years, 10 months ago by mohsen Modified:
3 years, 10 months ago Reviewers:
tdanderson CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove non-MD test coverage from TrayDetailsViewTest
Test coverage for touch feedback is removed. Also, some tests that
checked non-MD version of TrayDetailsView are updaed.
BUG=685837
TEST=TrayDetailsViewTest.* in ash_unittests
Review-Url: https://codereview.chromium.org/2681963002
Cr-Commit-Position: refs/heads/master@{#449203}
Committed: https://chromium.googlesource.com/chromium/src/+/2254cd2051623bbe445fd16da8aabcb16d37b0f4
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removed TODO #Messages
Total messages: 23 (16 generated)
The CQ bit was checked by mohsen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mohsen@chromium.org changed reviewers: + tdanderson@chromium.org
Please take a look...
LGTM with one nit https://codereview.chromium.org/2681963002/diff/1/ash/common/system/tray/tray... File ash/common/system/tray/tray_details_view_unittest.cc (right): https://codereview.chromium.org/2681963002/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_details_view_unittest.cc:49: void CreateExtraTitleRowButtons() override { nit: just remove this function completely. I will file a bug against myself to track the TODO below.
The CQ bit was checked by mohsen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdanderson@chromium.org Link to the patchset: https://codereview.chromium.org/2681963002/#ps20001 (title: "Removed TODO")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2681963002/diff/1/ash/common/system/tray/tray... File ash/common/system/tray/tray_details_view_unittest.cc (right): https://codereview.chromium.org/2681963002/diff/1/ash/common/system/tray/tray... ash/common/system/tray/tray_details_view_unittest.cc:49: void CreateExtraTitleRowButtons() override { On 2017/02/08 at 23:20:16, tdanderson wrote: > nit: just remove this function completely. I will file a bug against myself to track the TODO below. Done.
The CQ bit was unchecked by mohsen@chromium.org
The CQ bit was checked by mohsen@chromium.org
The CQ bit was unchecked by mohsen@chromium.org
The CQ bit was checked by mohsen@chromium.org to run a CQ dry run
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mohsen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486616034722760,
"parent_rev": "730c32f8d79bf4138ea171cfa9758fee8cb2d2d5", "commit_rev":
"2254cd2051623bbe445fd16da8aabcb16d37b0f4"}
Message was sent while issue was closed.
Description was changed from ========== Remove non-MD test coverage from TrayDetailsViewTest Test coverage for touch feedback is removed. Also, some tests that checked non-MD version of TrayDetailsView are updaed. BUG=685837 TEST=TrayDetailsViewTest.* in ash_unittests ========== to ========== Remove non-MD test coverage from TrayDetailsViewTest Test coverage for touch feedback is removed. Also, some tests that checked non-MD version of TrayDetailsView are updaed. BUG=685837 TEST=TrayDetailsViewTest.* in ash_unittests Review-Url: https://codereview.chromium.org/2681963002 Cr-Commit-Position: refs/heads/master@{#449203} Committed: https://chromium.googlesource.com/chromium/src/+/2254cd2051623bbe445fd16da8aa... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2254cd2051623bbe445fd16da8aa... |
