Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2681953002: Rename set_up_quic_server_info_factory to is_main_cache (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton, alexmos
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, Peter Beverloo, jam, net-reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename set_up_quic_server_info_factory to is_main_cache in HttpCache constructor so that future settings could be bundled with the same boolean. BUG=686632 Review-Url: https://codereview.chromium.org/2681953002 Cr-Commit-Position: refs/heads/master@{#448859} Committed: https://chromium.googlesource.com/chromium/src/+/4928bd5160bb22433aff3dc42d2c2773e4f09b9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert_net/cert_net_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_cache.h View 1 chunk +4 lines, -3 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/mock_http_cache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/mock_http_cache.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/url_request/view_cache_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Zhongyi Shi
Ryan, ptal! Let me know whether this CL makes sense. I prefer to separate it ...
3 years, 10 months ago (2017-02-08 00:45:49 UTC) #7
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-08 00:52:45 UTC) #8
Zhongyi Shi
alexmos@: content/shell/broswser/ change, ptal!
3 years, 10 months ago (2017-02-08 01:03:00 UTC) #11
alexmos
LGTM
3 years, 10 months ago (2017-02-08 02:08:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681953002/1
3 years, 10 months ago (2017-02-08 02:10:19 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:17:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4928bd5160bb22433aff3dc42d2c...

Powered by Google App Engine
This is Rietveld 408576698