Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2681913002: Use the flow of the linebox's containing block when placing ellipsis (Closed)

Created:
3 years, 10 months ago by rhogan
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the flow of the linebox's containing block when placing ellipsis This was a regression I introduced in crrev.com/2611233002- restore the old behaviour by referencing the flow of the linebox's containing block rather than its potentially inline container. BUG=688957 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2681913002 Cr-Commit-Position: refs/heads/master@{#449151} Committed: https://chromium.googlesource.com/chromium/src/+/d38d6d4342779d08233a32c8c70b835fe3e6b96f

Patch Set 1 #

Patch Set 2 : bug 688957 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
rhogan
3 years, 10 months ago (2017-02-07 22:00:02 UTC) #8
eae
OK, LGTM
3 years, 10 months ago (2017-02-07 22:15:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681913002/20001
3 years, 10 months ago (2017-02-08 18:48:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/384382)
3 years, 10 months ago (2017-02-08 20:59:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681913002/20001
3 years, 10 months ago (2017-02-08 22:00:53 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 00:10:29 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d38d6d4342779d08233a32c8c70b...

Powered by Google App Engine
This is Rietveld 408576698