Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2681873002: Reland: Fold UpdateModel into UpdateScreen. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Fold UpdateModel into UpdateScreen. Original CL: https://codereview.chromium.org/2673943002/ BUG=672142 Review-Url: https://codereview.chromium.org/2681873002 Cr-Commit-Position: refs/heads/master@{#448718} Committed: https://chromium.googlesource.com/chromium/src/+/3b772e23dc0971200d2dcf38f6305091e4d01813

Patch Set 1 : Original (reverted) patch #

Patch Set 2 : Fix compile for non-official builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -247 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_update_screen.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_update_screen.cc View 1 chunk +7 lines, -7 lines 0 comments Download
D chrome/browser/chromeos/login/screens/update_model.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/chromeos/login/screens/update_model.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 4 chunks +32 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 11 chunks +122 lines, -123 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jdufault
achuith@ PTAL. There were some compile errors only exposed after the patch landed.
3 years, 10 months ago (2017-02-07 18:41:29 UTC) #5
achuithb
lgtm
3 years, 10 months ago (2017-02-07 20:12:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681873002/20001
3 years, 10 months ago (2017-02-07 20:14:15 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:22:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b772e23dc0971200d2dcf38f630...

Powered by Google App Engine
This is Rietveld 408576698