Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2681803005:
[Payments] Prefill card holder name as the new billing address name (Closed)
|
Created:
3 years, 10 months ago by gogerald1 Modified:
3 years, 10 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrefill card holder name as the new billing address name
BUG=690032
Review-Url: https://codereview.chromium.org/2681803005
Cr-Commit-Position: refs/heads/master@{#449062}
Committed: https://chromium.googlesource.com/chromium/src/+/2d202f36763d65da162ca21e8bf91859a41fca1f
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #Messages
Total messages: 22 (17 generated)
Description was changed from ========== Prefill card holder name as the new billing address name BUG= ========== to ========== Prefill card holder name as the new billing address name BUG=690032 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gogerald@chromium.org changed reviewers: + rouslan@chromium.org
Hi rouslan@, PTAL, check the result on the bug,
LGTM % comment https://codereview.chromium.org/2681803005/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java (right): https://codereview.chromium.org/2681803005/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:689: } Great to see handling of server cards! :-D This maybe simpler (6 lines shorter and has 1 fewer conditional): AutofillProfile profile = isAddingNewAddress ? new AutofillProfile() : findTargetProfile(mProfilesForBillingAddress, eventData.first); if (TextUtils.isEmpty(profile.getFullname())) { profile.setFullname(card.getIsLocal() ? mNameField.getValue().toString() : card.getName()); } mAdressEditor.edit(new AutofillAddress(mContext, profile), new Callback...
Patchset #2 (id:60001) has been deleted
Thanks, sending to CQ soon https://codereview.chromium.org/2681803005/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java (right): https://codereview.chromium.org/2681803005/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:689: } On 2017/02/08 18:12:48, rouslan wrote: > Great to see handling of server cards! :-D > > This maybe simpler (6 lines shorter and has 1 fewer conditional): > > AutofillProfile profile = isAddingNewAddress > ? new AutofillProfile() > : findTargetProfile(mProfilesForBillingAddress, eventData.first); > if (TextUtils.isEmpty(profile.getFullname())) { > profile.setFullname(card.getIsLocal() > ? mNameField.getValue().toString() > : card.getName()); > } > > mAdressEditor.edit(new AutofillAddress(mContext, profile), new Callback... Done.
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gogerald@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2681803005/#ps80001 (title: "address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486581978276760,
"parent_rev": "9921a9244434543677f056d80be44bc28fe25d06", "commit_rev":
"2d202f36763d65da162ca21e8bf91859a41fca1f"}
Message was sent while issue was closed.
Description was changed from ========== Prefill card holder name as the new billing address name BUG=690032 ========== to ========== Prefill card holder name as the new billing address name BUG=690032 Review-Url: https://codereview.chromium.org/2681803005 Cr-Commit-Position: refs/heads/master@{#449062} Committed: https://chromium.googlesource.com/chromium/src/+/2d202f36763d65da162ca21e8bf9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as https://chromium.googlesource.com/chromium/src/+/2d202f36763d65da162ca21e8bf9... |
