Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2681803003: [cipd] make creating instances from cipd installations work. (Closed)

Created:
3 years, 10 months ago by iannucci
Modified:
3 years, 10 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix it probably #

Total comments: 1

Patch Set 3 : Add some tests #

Patch Set 4 : windows tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -7 lines) Patch
M cipd/client/cipd/local/builder.go View 1 chunk +6 lines, -1 line 0 comments Download
M cipd/client/cipd/local/files.go View 1 2 4 chunks +36 lines, -6 lines 0 comments Download
M cipd/client/cipd/local/files_test.go View 1 2 3 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
iannucci
3 years, 10 months ago (2017-02-08 02:41:30 UTC) #1
Vadim Sh.
https://codereview.chromium.org/2681803003/diff/1/cipd/client/cipd/local/files.go File cipd/client/cipd/local/files.go (right): https://codereview.chromium.org/2681803003/diff/1/cipd/client/cipd/local/files.go#newcode141 cipd/client/cipd/local/files.go:141: if root == dir && filepath.Join(root, SiteServiceDir) == abs ...
3 years, 10 months ago (2017-02-08 02:46:51 UTC) #2
iannucci
https://codereview.chromium.org/2681803003/diff/1/cipd/client/cipd/local/files.go File cipd/client/cipd/local/files.go (right): https://codereview.chromium.org/2681803003/diff/1/cipd/client/cipd/local/files.go#newcode141 cipd/client/cipd/local/files.go:141: if root == dir && filepath.Join(root, SiteServiceDir) == abs ...
3 years, 10 months ago (2017-02-08 02:53:49 UTC) #3
Vadim Sh.
https://codereview.chromium.org/2681803003/diff/20001/cipd/client/cipd/local/files.go File cipd/client/cipd/local/files.go (right): https://codereview.chromium.org/2681803003/diff/20001/cipd/client/cipd/local/files.go#newcode232 cipd/client/cipd/local/files.go:232: info, err = os.Stat(abs) nit: targetAbs, maybe?.. So save ...
3 years, 10 months ago (2017-02-08 02:54:55 UTC) #4
iannucci
Added some tests, manually verified that it works too :)
3 years, 10 months ago (2017-02-08 05:09:41 UTC) #5
Vadim Sh.
lgtm
3 years, 10 months ago (2017-02-08 05:24:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681803003/40001
3 years, 10 months ago (2017-02-08 07:58:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/34358c704d0f2a10)
3 years, 10 months ago (2017-02-08 08:08:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681803003/60001
3 years, 10 months ago (2017-02-08 08:12:22 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 08:19:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/9713e46074c62af9469ada39da61164274c3295f

Powered by Google App Engine
This is Rietveld 408576698