Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2681763002: X87: [turbofan] Pass Runtime::FunctionId to TrapIf and TrapUnless isel methods. (Closed)

Created:
3 years, 10 months ago by zhengxing.li
Modified:
3 years, 10 months ago
Reviewers:
titzer, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Pass Runtime::FunctionId to TrapIf and TrapUnless isel methods. port b29d6d4968ffc2ef602df1977c65c6b7fd8f1975(r41790) original commit message: This also fixes UBSAN failures due to improper OpParameter<> calls. BUG= Review-Url: https://codereview.chromium.org/2681763002 Cr-Commit-Position: refs/heads/master@{#43022} Committed: https://chromium.googlesource.com/v8/v8/+/167053b03230dd3853b0ea7c725dfd4077a861d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 10 months ago (2017-02-07 14:46:37 UTC) #2
titzer
lgtm
3 years, 10 months ago (2017-02-07 17:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681763002/1
3 years, 10 months ago (2017-02-08 01:21:34 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 01:49:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/167053b03230dd3853b0ea7c725dfd4077a...

Powered by Google App Engine
This is Rietveld 408576698