Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2681753002: blink_gc_plugin: report illegal on-heap iterators as warnings/errors. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink_gc_plugin: report illegal on-heap iterators as warnings/errors. Fix classification bug, when encountered this should be reported as a warning/error, not as a supplementary note. R= BUG= Review-Url: https://codereview.chromium.org/2681753002 Cr-Commit-Position: refs/heads/master@{#448932} Committed: https://chromium.googlesource.com/chromium/src/+/3bc3b9130cbb864cba7abbe8e9ee9fd616855696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M tools/clang/blink_gc_plugin/DiagnosticsReporter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/fields_illegal_tracing.txt View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/fields_illegal_tracing.txt View 3 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-07 14:25:40 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-07 15:23:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681753002/1
3 years, 10 months ago (2017-02-08 07:44:33 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 07:49:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bc3b9130cbb864cba7abbe8e9ee...

Powered by Google App Engine
This is Rietveld 408576698