webkitpy: Consolidate code for MANIFEST.json into wpt_manifest.py

webkitpy: Consolidate code for MANIFEST.json into wpt_manifest.py

Review-Url: https://codereview.chromium.org/2681733005
Cr-Commit-Position: refs/heads/master@{#449567}
Committed: https://chromium.googlesource.com/chromium/src/+/7732e7be9c67ace7622b1462b344210725f4baa1

[tkent, 2017-02-09 07:41:16]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 07:41:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 08:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 08:45:49]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-09 09:05:32]

tkent@chromium.org changed reviewers:
+ qyearsley@chromium.org

[tkent, 2017-02-09 09:05:32]

qyearsley@, would you review this please?

[qyearsley, 2017-02-09 17:29:48]

lgtm with nits, thanks for doing this

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py (right):

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py:6: """
Minor rephrasing: "WPTManifest is responsible for handling MANIFEST.json."

You could also add a bit more background context, e.g.:

The MANIFEST.json file contains metadata about files in web-platform-tests,
such as what tests exist, and extra information about each test, including
test type, options, URLs to use, and reference file paths if applicable.

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py:40: self.raw_dict
= json.loads(json_content)
Nit: __init__ could be moved to the top of the class, above generate_manifest.

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py:89: """Extract
reference information of the specified reference test.
Extract -> Extracts

[tkent, 2017-02-10 08:05:02]

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py (right):

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py:6: """
On 2017/02/09 at 17:29:48, qyearsley wrote:
> Minor rephrasing: "WPTManifest is responsible for handling MANIFEST.json."
> 
> You could also add a bit more background context, e.g.:
> 
> The MANIFEST.json file contains metadata about files in web-platform-tests,
> such as what tests exist, and extra information about each test, including
> test type, options, URLs to use, and reference file paths if applicable.

Copied them.  Thanks :)

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py:40: self.raw_dict
= json.loads(json_content)
On 2017/02/09 at 17:29:48, qyearsley wrote:
> Nit: __init__ could be moved to the top of the class, above generate_manifest.

Done.

https://codereview.chromium.org/2681733005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py:89: """Extract
reference information of the specified reference test.
On 2017/02/09 at 17:29:48, qyearsley wrote:
> Extract -> Extracts

Done.

[tkent, 2017-02-10 08:05:35]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-10 08:05:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2681733005/#ps20001
(title: "Apply review comments")

[commit-bot: I haz the power, 2017-02-10 08:05:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 09:10:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486713935221200,
"parent_rev": "e6c3572f606276d54cfde5c9dbdf2bc22f88be02", "commit_rev":
"7732e7be9c67ace7622b1462b344210725f4baa1"}

[commit-bot: I haz the power, 2017-02-10 09:10:59]

Description was changed from

==========
webkitpy: Consolidate code for MANIFEST.json into wpt_manifest.py
==========

to

==========
webkitpy: Consolidate code for MANIFEST.json into wpt_manifest.py

Review-Url: https://codereview.chromium.org/2681733005
Cr-Commit-Position: refs/heads/master@{#449567}
Committed:
https://chromium.googlesource.com/chromium/src/+/7732e7be9c67ace7622b1462b344...
==========

[commit-bot: I haz the power, 2017-02-10 09:11:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7732e7be9c67ace7622b1462b344...