Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2681733003: Remove duplicate layout tests for nav timing 2 (Closed)

Created:
3 years, 10 months ago by sunjian
Modified:
3 years, 9 months ago
Reviewers:
panicker
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate layout tests for nav timing 2. Wpt tests on github have been successfully imported into chromium. We can safely get rid of the temporary tests we had in w3c/webperf/approved directory. BUG=689750 Review-Url: https://codereview.chromium.org/2681733003 Cr-Commit-Position: refs/heads/master@{#449386} Committed: https://chromium.googlesource.com/chromium/src/+/1ca5643f742618f334b63db2fb3cd7219943d585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1167 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_idlharness.html View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_idlharness-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_attributes_exist.html View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_attributes_values.html View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_document_open.html View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigate_within_document.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigation_type_backforward.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigation_type_navigate.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigation_type_reload.html View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_open_blank_page.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_open_data_uri.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_none.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_server.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_xserver.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_xserver_opt_in.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unique_nav_instances.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_no_previous_document.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_previous_document_cross_origin.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_with_cross_origin_redirects.html View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_with_previous_document.html View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
panicker
lgtm
3 years, 10 months ago (2017-02-09 19:10:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681733003/1
3 years, 10 months ago (2017-02-09 19:10:57 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 20:16:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ca5643f742618f334b63db2fb3c...

Powered by Google App Engine
This is Rietveld 408576698