Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2681723003: Add a deprecation warning for notifications on insecure contexts. (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 10 months ago
CC:
asvitkine+watch_chromium.org, awdf+watch_chromium.org, blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, haraken, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a deprecation warning for notifications on insecure contexts. This CL adds a deprecation warning for the M60 removal of access to the Notifications API on insecure contexts. See the blink-dev Intent to Deprecate and Remove thread at https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/IVgkxkRNtMo for more information. BUG=679821 Review-Url: https://codereview.chromium.org/2681723003 Cr-Commit-Position: refs/heads/master@{#449180} Committed: https://chromium.googlesource.com/chromium/src/+/416b2f1ded0eb7454dc1e84600341bbd75dd23ed

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 3 chunks +11 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
dominickn
jochen: PTAL, thanks!
3 years, 10 months ago (2017-02-08 05:05:39 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-08 09:01:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681723003/1
3 years, 10 months ago (2017-02-08 12:42:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/384073)
3 years, 10 months ago (2017-02-08 12:47:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681723003/20001
3 years, 10 months ago (2017-02-09 01:17:38 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 01:29:31 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/416b2f1ded0eb7454dc1e8460034...

Powered by Google App Engine
This is Rietveld 408576698