Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2681633002: Fix min-content sizing for 'word-break: break-word' (Closed)

Created:
3 years, 10 months ago by kojii
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix min-content sizing for 'word-break: break-word' This patch fixes min-content[1] sizing for 'word-break: break-word'. The fix for crbug.com/655590 computes min-content sizing for 'break-word' the same as 'break-all', even though these two values have different break opportunities as per the spec[2]. Due to this, when 'break-word' is applied to text which 'break-all' does not allow break, such as a long sequence of '.' (FULL STOP, a.k.a. period,) the min-content becomes too long. [1] https://drafts.csswg.org/css-sizing/#min-content [2] https://drafts.csswg.org/css-text-3/#word-break-property BUG=687338 Review-Url: https://codereview.chromium.org/2681633002 Cr-Commit-Position: refs/heads/master@{#448744} Committed: https://chromium.googlesource.com/chromium/src/+/eb5a8c59e9f3121d5c0dc92b2539f86f847eb295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
A third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-break-word-fit-content.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-break-word-fit-content-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 4 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kojii
PTAL.
3 years, 10 months ago (2017-02-07 04:52:57 UTC) #7
eae
LGTM
3 years, 10 months ago (2017-02-07 17:40:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681633002/1
3 years, 10 months ago (2017-02-07 22:11:59 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:28:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb5a8c59e9f3121d5c0dc92b2539...

Powered by Google App Engine
This is Rietveld 408576698