Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2681583002: Fix get_ports_rpc_test to be insensitive to system level ports (Closed)

Created:
3 years, 10 months ago by Cutch
Modified:
3 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix get_ports_rpc_test to be insensitive to system level ports Fixes #28560 BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/25e8f56425f4d9ea99d87799bc2d37fa3b374fc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/observatory/tests/service/get_ports_rpc_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
3 years, 10 months ago (2017-02-06 21:36:40 UTC) #2
rmacnak
LGTM
3 years, 10 months ago (2017-02-06 21:43:34 UTC) #3
Cutch
3 years, 10 months ago (2017-02-06 21:43:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
25e8f56425f4d9ea99d87799bc2d37fa3b374fc6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698