Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Side by Side Diff: runtime/observatory/tests/service/get_ports_rpc_test.dart

Issue 2681583002: Fix get_ports_rpc_test to be insensitive to system level ports (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 library get_ports_rpc_test; 6 library get_ports_rpc_test;
7 7
8 import 'dart:isolate' hide Isolate; 8 import 'dart:isolate' hide Isolate;
9 import 'package:observatory/service_io.dart'; 9 import 'package:observatory/service_io.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
(...skipping 26 matching lines...) Expand all
37 bool closureMatcher(handler) { 37 bool closureMatcher(handler) {
38 return handler.isClosure; 38 return handler.isClosure;
39 } 39 }
40 40
41 var tests = [ 41 var tests = [
42 (Isolate isolate) async { 42 (Isolate isolate) async {
43 var result = await isolate.invokeRpc('_getPorts', {}); 43 var result = await isolate.invokeRpc('_getPorts', {});
44 expect(result['type'], equals('_Ports')); 44 expect(result['type'], equals('_Ports'));
45 expect(result['ports'], isList); 45 expect(result['ports'], isList);
46 var ports = result['ports']; 46 var ports = result['ports'];
47 // There are three ports: the two created in warmup and the stdin listener 47 // There are at least two ports: the two created in warm up. Some OSes
48 // created by the test harness. 48 // will have other ports open but we do not try and test for these.
49 expect(ports.length, equals(3)); 49 expect(ports.length, greaterThanOrEqualTo(2));
50 expect(countHandlerMatches(ports, nullMatcher), equals(1)); 50 expect(countHandlerMatches(ports, nullMatcher), greaterThanOrEqualTo(1));
51 expect(countHandlerMatches(ports, closureMatcher), equals(2)); 51 expect(countHandlerMatches(ports, closureMatcher), greaterThanOrEqualTo(1));
52 }, 52 },
53 ]; 53 ];
54 54
55 main(args) async => runIsolateTests(args, tests, testeeBefore:warmup); 55 main(args) async => runIsolateTests(args, tests, testeeBefore:warmup);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698