Issue 2681463003: Fix Observatory timeline export to be compatible with about:tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2681463003: Fix Observatory timeline export to be compatible with about:tracing (Closed)

Created:
3 years, 10 months ago by Cutch

Modified:
3 years, 10 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix Observatory timeline export to be compatible with about:tracing Fixes #28628 Recent versions of about:tracing now assume the presence of a 'name' property in a Sample (ph='P') event. Add a blank one to avoid an exception. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5142fa58cec343e1a4f7fe4fedcd861067733a98

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/profiler_service.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Cutch

3 years, 10 months ago (2017-02-07 16:43:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5142fa58cec343e1a4f7fe4fedcd861067733a98 (presubmit successful).