Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: runtime/vm/profiler_service.cc

Issue 2681463003: Fix Observatory timeline export to be compatible with about:tracing (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_service.cc
diff --git a/runtime/vm/profiler_service.cc b/runtime/vm/profiler_service.cc
index 6731e2d91d8f167723070a34cc0871c441943999..679847aebe65df02c0df3a1ccd59f71c0362ac79 100644
--- a/runtime/vm/profiler_service.cc
+++ b/runtime/vm/profiler_service.cc
@@ -2419,6 +2419,8 @@ void Profile::PrintTimelineJSON(JSONStream* stream) {
ProcessedSample* sample = samples_->At(sample_index);
JSONObject event(&events);
event.AddProperty("ph", "P"); // kind = sample event
+ // Add a blank name to keep about:tracing happy.
+ event.AddProperty("name", "");
event.AddProperty64("pid", pid);
event.AddProperty64("tid", OSThread::ThreadIdToIntPtr(sample->tid()));
event.AddPropertyTimeMicros("ts", sample->timestamp());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698