Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2681463002: [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:eg_tests to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2681463002 Cr-Commit-Position: refs/heads/master@{#450779} Committed: https://chromium.googlesource.com/chromium/src/+/2721a1e8771f3880b23ed94c787d9a1d3dd4cefd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
stkhapugin
PTAL ٩(- ̮̮̃-̃)۶
3 years, 10 months ago (2017-02-06 17:37:35 UTC) #4
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-06 18:26:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681463002/1
3 years, 10 months ago (2017-02-15 16:04:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/119498)
3 years, 10 months ago (2017-02-15 17:40:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681463002/1
3 years, 10 months ago (2017-02-15 18:05:47 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:49:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2721a1e8771f3880b23ed94c787d...

Powered by Google App Engine
This is Rietveld 408576698