Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2681413003: Disable flaky CaptivePortalBlockingPageTest tests on Mac (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
lgarron
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky CaptivePortalBlockingPageTest tests on Mac BUG=690125, 690170 Review-Url: https://codereview.chromium.org/2681413003 Cr-Commit-Position: refs/heads/master@{#449410} Committed: https://chromium.googlesource.com/chromium/src/+/a719452bb0c96d0b746b92c1917031bb94849c93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc View 1 chunk +16 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
meacer
lgarron: PTAL?
3 years, 10 months ago (2017-02-09 20:45:27 UTC) #4
lgarron
rubber stamp LGTM (sigh, I've got my own flaky test right now, too)
3 years, 10 months ago (2017-02-09 20:52:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681413003/1
3 years, 10 months ago (2017-02-09 20:54:42 UTC) #9
meacer
On 2017/02/09 20:52:03, lgarron wrote: > rubber stamp LGTM > > (sigh, I've got my ...
3 years, 10 months ago (2017-02-09 20:55:31 UTC) #10
lgarron
On 2017/02/09 at 20:55:31, meacer wrote: > On 2017/02/09 20:52:03, lgarron wrote: > > rubber ...
3 years, 10 months ago (2017-02-09 21:17:48 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 21:19:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a719452bb0c96d0b746b92c19170...

Powered by Google App Engine
This is Rietveld 408576698