MD Settings: Disable MdSettingsUITest.ViewSourceDoesntCrash when Vulcanized.

MD Settings: Disable MdSettingsUITest.ViewSourceDoesntCrash when Vulcanized.

The test times out on ChromeOS, which indicates that "view source" does not
handle well large files.

BUG=673825
Review-Url: https://codereview.chromium.org/2681413002
Cr-Commit-Position: refs/heads/master@{#449509}
Committed: https://chromium.googlesource.com/chromium/src/+/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0

[dpapad, 2017-02-09 20:20:48]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-02-09 20:21:38]

BTW, since we have USE_VULCANIZE flag on by default, temporarily this will mean
that the test is completely disabled. Once we switch back debug builds to
USE_VULCANIZE false, this test will be basically running on debug builds only.

[Dan Beam, 2017-02-09 20:32:10]

On 2017/02/09 20:21:38, dpapad wrote:
> BTW, since we have USE_VULCANIZE flag on by default, temporarily this will
mean
> that the test is completely disabled. Once we switch back debug builds to
> USE_VULCANIZE false, this test will be basically running on debug builds only.

yep, understood

lgtm

[Dan Beam, 2017-02-09 20:32:56]

https://codereview.chromium.org/2681413002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc (right):

https://codereview.chromium.org/2681413002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc:32:
chrome::kChromeUIMdSettingsURL));
fwiw: you could also just try to load something smaller that still exists when
vulcanized, maybe?  like string.js or something?

[dpapad, 2017-02-09 23:41:25]

https://codereview.chromium.org/2681413002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc (right):

https://codereview.chromium.org/2681413002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc:32:
chrome::kChromeUIMdSettingsURL));
On 2017/02/09 at 20:32:56, Dan Beam wrote:
> fwiw: you could also just try to load something smaller that still exists when
vulcanized, maybe?  like string.js or something?

Done.

[Dan Beam, 2017-02-09 23:46:13]

https://codereview.chromium.org/2681413002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc (right):

https://codereview.chromium.org/2681413002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc:33:
url.append("strings.js");
you can just load this when unvulcanized as well...

[dpapad, 2017-02-10 00:01:14]

Patchset #3 (id:40001) has been deleted

[dpapad, 2017-02-10 00:02:46]

https://codereview.chromium.org/2681413002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc (right):

https://codereview.chromium.org/2681413002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc:33:
url.append("strings.js");
On 2017/02/09 at 23:46:13, Dan Beam wrote:
> you can just load this when unvulcanized as well...

Done.

[dpapad, 2017-02-10 00:37:24]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-02-10 00:37:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2681413002/#ps60001
(title: "Nit")

[commit-bot: I haz the power, 2017-02-10 00:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 01:36:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486687044769870,
"parent_rev": "bf11b55a9f6874eed37da83fe741494e39e4b3b9", "commit_rev":
"7bca188f60e1398463fc64d9fdc7eab6bc13d0a0"}

[commit-bot: I haz the power, 2017-02-10 01:37:13]

Description was changed from

==========
MD Settings: Disable MdSettingsUITest.ViewSourceDoesntCrash when Vulcanized.

The test times out on ChromeOS, which indicates that "view source" does not
handle well large files.

BUG=673825
==========

to

==========
MD Settings: Disable MdSettingsUITest.ViewSourceDoesntCrash when Vulcanized.

The test times out on ChromeOS, which indicates that "view source" does not
handle well large files.

BUG=673825

Review-Url: https://codereview.chromium.org/2681413002
Cr-Commit-Position: refs/heads/master@{#449509}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bca188f60e1398463fc64d9fdc7...
==========

[commit-bot: I haz the power, 2017-02-10 01:37:14]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7bca188f60e1398463fc64d9fdc7...